Adjust visual overflow rect for rounded/shifted ascent/descent

third_party/WebKit/Source/core/layout/LayoutText.cpp

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 1939 matching lines @@
     LayoutRect logicalVisualOverflow = curr->logicalOverflowRect();
     logicalLeftSide = std::min(logicalLeftSide, logicalVisualOverflow.x());
     logicalRightSide = std::max(logicalRightSide, logicalVisualOverflow.maxX());
   }
 
   LayoutUnit logicalTop = firstTextBox()->logicalTopVisualOverflow();
   LayoutUnit logicalWidth = logicalRightSide - logicalLeftSide;
   LayoutUnit logicalHeight =
       lastTextBox()->logicalBottomVisualOverflow() - logicalTop;
 
+  // Inflate visual overflow if we have adjusted ascent/descent causing the

[eae, 2017/04/07 17:41:57]

This is better, thank you. I'm still not convinced it is correct however.

[Xianzhu, 2017/04/07 18:02:52]

What do you think about my previous comment:
https://codereview.chromium.org/2803483002/diff/40001/third_party/WebKit/Sour...
?

+  // painted glyphs to overflow the layout geometries based on the adjusted
+  // ascent/descent.
+  auto inflationForAscent = styleRef(firstTextBox()->isFirstLineStyle())
+                                .font()
+                                .primaryFont()

[eae, 2017/04/07 17:41:57]

primaryFont may be null.

[Xianzhu, 2017/04/07 18:02:53]

Done.

Should we have DCHECK(primaryFont) here? I saw many existing such DCHECKs.

+                                ->getFontMetrics()
+                                .visualOverflowInflationForAscent();
+  auto inflationForDescent = styleRef(lastTextBox()->isFirstLineStyle())
+                                 .font()
+                                 .primaryFont()
+                                 ->getFontMetrics()
+                                 .visualOverflowInflationForDescent();
+  logicalTop -= inflationForAscent;
+  logicalHeight += inflationForAscent + inflationForDescent;
+
   LayoutRect rect(logicalLeftSide, logicalTop, logicalWidth, logicalHeight);
   if (!style()->isHorizontalWritingMode())
     rect = rect.transposedRect();
   return rect;
 }
 
 LayoutRect LayoutText::localVisualRect() const {
   if (style()->visibility() != EVisibility::kVisible)
     return LayoutRect();
 
@@ skipping 122 matching lines @@
   LayoutRect rect = LayoutRect(
       IntRect(firstRunX(), firstRunY(), linesBox.width(), linesBox.height()));
   LayoutBlock* block = containingBlock();
   if (block && hasTextBoxes())
     block->adjustChildDebugRect(rect);
 
   return rect;
 }
 
 }  // namespace blink