[Payments] Added region load failure tolerance and tests to PR editor.

chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_SHIPPING_ADDRESS_EDITOR_VIEW_CONTROLLER_H_
 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_SHIPPING_ADDRESS_EDITOR_VIEW_CONTROLLER_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 35 matching lines @@
   class ShippingAddressValidationDelegate : public ValidationDelegate {
    public:
     ShippingAddressValidationDelegate(
         ShippingAddressEditorViewController* parent,
         const EditorField& field);
     ~ShippingAddressValidationDelegate() override;
 
     // ValidationDelegate:
     bool ValidateTextfield(views::Textfield* textfield) override;
     bool ValidateCombobox(views::Combobox* combobox) override;
+    void ComboboxModelChanged(views::Combobox* combobox) override;
 
    private:
     bool ValidateValue(const base::string16& value);
 
     EditorField field_;
+
     // Raw pointer back to the owner of this class, therefore will not be null.
     ShippingAddressEditorViewController* controller_;
 
     DISALLOW_COPY_AND_ASSIGN(ShippingAddressValidationDelegate);
   };
   friend class ShippingAddressValidationDelegate;
 
   // List of fields, reset everytime the current country changes.
   std::vector<EditorField> editor_fields_;
 
   // The currently chosen country. Defaults to 0 as the first entry in the
   // combobox, which is the generated default value received from
   // autofill::CountryComboboxModel::countries() which is documented to always
   // have the default country at the top as well as within the sorted list.
   size_t chosen_country_index_{0};
 
   // The list of country codes as ordered in the country combobox model.
   std::vector<std::string> country_codes_;
 
+  // Identifies whether we tried and failed to load region data.
+  bool failed_to_load_region_data_{false};
+
   // Updates |editor_fields_| based on the current country.
   void UpdateEditorFields();
 
-  // Called by the validation delegate when the country combobox changed.
-  void OnCountryChanged(views::Combobox* combobox);
+  // Called when data changes need to force a view update.
+  void OnDataChanged();
+
+  // When a combobox model has changed, a view update might be needed, e.g., if
+  // there is no data in the combox and it must be converted to a text field.

[Mathieu, 2017/04/05 00:25:14]

nit: combobox

[MAD, 2017/04/07 18:50:40]

Done.

+  void OnComboboxModelChanged(views::Combobox* combobox);
 
   DISALLOW_COPY_AND_ASSIGN(ShippingAddressEditorViewController);
 };
 
 }  // namespace payments
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PAYMENTS_SHIPPING_ADDRESS_EDITOR_VIEW_CONTROLLER_H_