third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.h - Issue 2803433002: [LayoutNG] Initial support for the 'vertical-align' property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.h

Issue 2803433002: [LayoutNG] Initial support for the 'vertical-align' property (Closed)

Patch Set: Move all On*() to NGInlineLayoutStateStack Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_line_height_metrics.cc ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.h

index 4837398409bf156e4e23160035fe34dfa7ecbc98..c88c307e17d21d60b1f23453235cf27059ca4d69 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.h

@@ -23,8 +23,7 @@ class CORE_EXPORT NGTextFragmentBuilder final {

NGTextFragmentBuilder& SetDirection(TextDirection);

- NGTextFragmentBuilder& SetInlineSize(LayoutUnit);

- NGTextFragmentBuilder& SetBlockSize(LayoutUnit);

+ NGTextFragmentBuilder& SetSize(const NGLogicalSize&);

void UniteMetrics(const NGLineHeightMetrics&);

const NGLineHeightMetrics& Metrics() const { return metrics_; }