Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Issue 2803413002: DevTools: brush up paint marker rendering, sort experiments, restore event markers on the overview. (Closed)
Patch Set: fixed the test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 99
100 /** 100 /**
101 * @param {!SDK.TracingModel.Event} event 101 * @param {!SDK.TracingModel.Event} event
102 * @return {boolean} 102 * @return {boolean}
103 */ 103 */
104 static isMarkerEvent(event) { 104 static isMarkerEvent(event) {
105 const recordTypes = TimelineModel.TimelineModel.RecordType; 105 const recordTypes = TimelineModel.TimelineModel.RecordType;
106 switch (event.name) { 106 switch (event.name) {
107 case recordTypes.TimeStamp: 107 case recordTypes.TimeStamp:
108 case recordTypes.MarkFirstPaint: 108 case recordTypes.MarkFirstPaint:
109 case recordTypes.FirstTextPaint: 109 case recordTypes.MarkFMP:
110 case recordTypes.FirstImagePaint: 110 case recordTypes.MarkFMPCandidate:
111 case recordTypes.FirstMeaningfulPaint:
112 case recordTypes.FirstPaint:
113 case recordTypes.FirstContentfulPaint:
114 return true; 111 return true;
115 case recordTypes.MarkDOMContent: 112 case recordTypes.MarkDOMContent:
116 case recordTypes.MarkLoad: 113 case recordTypes.MarkLoad:
117 return event.args['data']['isMainFrame']; 114 return event.args['data']['isMainFrame'];
118 default: 115 default:
119 return false; 116 return false;
120 } 117 }
121 } 118 }
122 119
123 /** 120 /**
(...skipping 959 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 1080
1084 XHRReadyStateChange: 'XHRReadyStateChange', 1081 XHRReadyStateChange: 'XHRReadyStateChange',
1085 XHRLoad: 'XHRLoad', 1082 XHRLoad: 'XHRLoad',
1086 CompileScript: 'v8.compile', 1083 CompileScript: 'v8.compile',
1087 EvaluateScript: 'EvaluateScript', 1084 EvaluateScript: 'EvaluateScript',
1088 1085
1089 CommitLoad: 'CommitLoad', 1086 CommitLoad: 'CommitLoad',
1090 MarkLoad: 'MarkLoad', 1087 MarkLoad: 'MarkLoad',
1091 MarkDOMContent: 'MarkDOMContent', 1088 MarkDOMContent: 'MarkDOMContent',
1092 MarkFirstPaint: 'MarkFirstPaint', 1089 MarkFirstPaint: 'MarkFirstPaint',
1090 MarkFMP: 'firstMeaningfulPaint',
1091 MarkFMPCandidate: 'firstMeaningfulPaintCandidate',
1093 1092
1094 TimeStamp: 'TimeStamp', 1093 TimeStamp: 'TimeStamp',
1095 ConsoleTime: 'ConsoleTime', 1094 ConsoleTime: 'ConsoleTime',
1096 UserTiming: 'UserTiming', 1095 UserTiming: 'UserTiming',
1097 1096
1098 FirstTextPaint: 'firstTextPaint',
1099 FirstImagePaint: 'firstImagePaint',
1100 FirstMeaningfulPaint: 'firstMeaningfulPaint',
1101 FirstPaint: 'firstPaint',
1102 FirstContentfulPaint: 'firstContentfulPaint',
1103
1104 ResourceSendRequest: 'ResourceSendRequest', 1097 ResourceSendRequest: 'ResourceSendRequest',
1105 ResourceReceiveResponse: 'ResourceReceiveResponse', 1098 ResourceReceiveResponse: 'ResourceReceiveResponse',
1106 ResourceReceivedData: 'ResourceReceivedData', 1099 ResourceReceivedData: 'ResourceReceivedData',
1107 ResourceFinish: 'ResourceFinish', 1100 ResourceFinish: 'ResourceFinish',
1108 1101
1109 RunMicrotasks: 'RunMicrotasks', 1102 RunMicrotasks: 'RunMicrotasks',
1110 FunctionCall: 'FunctionCall', 1103 FunctionCall: 'FunctionCall',
1111 GCEvent: 'GCEvent', // For backwards compatibility only, now replaced by Mino rGC/MajorGC. 1104 GCEvent: 'GCEvent', // For backwards compatibility only, now replaced by Mino rGC/MajorGC.
1112 MajorGC: 'MajorGC', 1105 MajorGC: 'MajorGC',
1113 MinorGC: 'MinorGC', 1106 MinorGC: 'MinorGC',
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
1804 var data = event[TimelineModel.TimelineData._symbol]; 1797 var data = event[TimelineModel.TimelineData._symbol];
1805 if (!data) { 1798 if (!data) {
1806 data = new TimelineModel.TimelineData(); 1799 data = new TimelineModel.TimelineData();
1807 event[TimelineModel.TimelineData._symbol] = data; 1800 event[TimelineModel.TimelineData._symbol] = data;
1808 } 1801 }
1809 return data; 1802 return data;
1810 } 1803 }
1811 }; 1804 };
1812 1805
1813 TimelineModel.TimelineData._symbol = Symbol('timelineData'); 1806 TimelineModel.TimelineData._symbol = Symbol('timelineData');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698