Support region selection for voice interaction session

chrome/browser/ui/ash/palette_delegate_chromeos.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/palette_delegate_chromeos.h"
 
 #include "ash/accelerators/accelerator_controller_delegate_aura.h"
 #include "ash/aura/wm_shell_aura.h"
 #include "ash/screenshot_delegate.h"
 #include "ash/shell.h"
 #include "ash/system/palette/palette_utils.h"
 #include "ash/utility/screenshot_controller.h"
+#include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/chromeos/arc/arc_util.h"
 #include "chrome/browser/chromeos/note_taking_helper.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/pref_names.h"
+#include "chromeos/chromeos_switches.h"
+#include "components/arc/arc_bridge_service.h"
+#include "components/arc/arc_service_manager.h"
+#include "components/arc/common/voice_interaction_framework.mojom.h"
 #include "components/prefs/pref_change_registrar.h"
 #include "components/prefs/pref_service.h"
 #include "components/user_manager/user_manager.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 
 namespace chromeos {
 
+class VoiceInteractionScreenshotDelegate : public ash::ScreenshotDelegate {
+ public:
+  explicit VoiceInteractionScreenshotDelegate(Profile* profile)
+      : profile_(profile) {}
+
+ private:
+  Profile* profile_;

[Luis Héctor Chávez, 2017/04/11 16:11:16]

nit: Profile* const profile_;

[Vladislav Kaznacheev, 2017/04/11 18:59:33]

Removed as unused.

+
+  void HandleTakeScreenshotForAllRootWindows() override { NOTIMPLEMENTED(); }
+
+  void HandleTakePartialScreenshot(aura::Window* window,
+                                   const gfx::Rect& rect) override {
+    arc::mojom::VoiceInteractionFrameworkInstance* framework =
+        ARC_GET_INSTANCE_FOR_METHOD(arc::ArcServiceManager::Get()
+                                        ->arc_bridge_service()
+                                        ->voice_interaction_framework(),
+                                    StartVoiceInteractionSessionForRegion);
+    if (!framework) {
+      LOG(ERROR) << "Cannot connect to ARC";

[dcheng, 2017/04/11 07:39:47]

Nit: please use DLOG

[Luis Héctor Chávez, 2017/04/11 16:11:16]

You can also remove this logging completely: ARC_GET_INSTANCE_FOR_METHOD already
does its own logging.

[Vladislav Kaznacheev, 2017/04/11 18:59:33]

Acknowledged.

[Vladislav Kaznacheev, 2017/04/11 18:59:33]

Done.

+      return;
+    }
+    double device_scale_factor = window->layer()->device_scale_factor();
+    framework->StartVoiceInteractionSessionForRegion(
+        gfx::ScaleToEnclosingRect(rect, device_scale_factor));
+  }
+
+  void HandleTakeWindowScreenshot(aura::Window* window) override {
+    NOTIMPLEMENTED();
+  }
+
+  bool CanTakeScreenshot() override { return true; }
+};
+
 PaletteDelegateChromeOS::PaletteDelegateChromeOS() : weak_factory_(this) {
   registrar_.Add(this, chrome::NOTIFICATION_SESSION_STARTED,
                  content::NotificationService::AllSources());
   registrar_.Add(this, chrome::NOTIFICATION_PROFILE_DESTROYED,
                  content::NotificationService::AllSources());
 }
 
 PaletteDelegateChromeOS::~PaletteDelegateChromeOS() {}
 
 std::unique_ptr<PaletteDelegateChromeOS::EnableListenerSubscription>
@@ skipping 96 matching lines @@
 
 void PaletteDelegateChromeOS::TakeScreenshot() {
   auto* screenshot_delegate = ash::WmShellAura::Get()
                                   ->accelerator_controller_delegate()
                                   ->screenshot_delegate();
   screenshot_delegate->HandleTakeScreenshotForAllRootWindows();
 }
 
 void PaletteDelegateChromeOS::TakePartialScreenshot(const base::Closure& done) {
   auto* screenshot_controller = ash::Shell::Get()->screenshot_controller();
-  auto* screenshot_delegate = ash::WmShellAura::Get()
-                                  ->accelerator_controller_delegate()
-                                  ->screenshot_delegate();
+
+  ash::ScreenshotDelegate* screenshot_delegate;
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+          chromeos::switches::kEnableVoiceInteraction) &&

[Luis Héctor Chávez, 2017/04/11 16:11:16]

nit: ArcVoiceInteractionFrameworkService::IsVoiceInteractionEnabled()

(let's try to keep switch inspection/manipulation constrained to a single
class).

[Vladislav Kaznacheev, 2017/04/11 18:59:33]

Done.

+      arc::IsArcAllowedForProfile(profile_)) {
+    if (!voice_interaction_screenshot_delegate_) {
+      voice_interaction_screenshot_delegate_ =
+          base::MakeUnique<VoiceInteractionScreenshotDelegate>(profile_);
+    }
+    screenshot_delegate = voice_interaction_screenshot_delegate_.get();
+  } else {
+    screenshot_delegate = ash::WmShellAura::Get()
+                              ->accelerator_controller_delegate()
+                              ->screenshot_delegate();
+  }
 
   screenshot_controller->set_pen_events_only(true);
   screenshot_controller->StartPartialScreenshotSession(
       screenshot_delegate, false /* draw_overlay_immediately */);
   screenshot_controller->set_on_screenshot_session_done(
       base::Bind(&PaletteDelegateChromeOS::OnPartialScreenshotDone,
                  weak_factory_.GetWeakPtr(), done));
 }
 
 void PaletteDelegateChromeOS::CancelPartialScreenshot() {
   ash::Shell::Get()->screenshot_controller()->CancelScreenshotSession();
 }
 
 }  // namespace chromeos