Issue 28034: Move the trace sorting from the JS up to the Python, matching what's done for...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28034: Move the trace sorting from the JS up to the Python, matching what's done for... (Closed)

Created:
11 years, 10 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move the trace sorting from the JS up to the Python, matching what's done for the graphs as a whole and allowing the use of the 'imoprtant' marker to determine the best sorting order. BUG=7704 TEST=make sure perf graphs have traces in the desired order Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10204

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -62 lines)			Patch
	M	tools/buildbot/perf/dashboard/ui/generic_plotter.html	View		1 chunk	+4 lines, -49 lines	0 comments	Download
	M	tools/buildbot/scripts/master/log_parser/process_log.py	View		3 chunks	+45 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

Thanks to JS not following its spec, this turned out to be more straightforward than ...

11 years, 10 months ago (2009-02-23 19:35:25 UTC) #1

LGTM

Expand Messages | Collapse Messages