third_party/WebKit/Source/core/layout/LayoutTableSection.h - Issue 2803383002: The first table row is pushed down by border-spacing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.h

Issue 2803383002: The first table row is pushed down by border-spacing. (Closed)

Patch Set: break-inside:avoid on a row shouldn't prevent breaking inside adjacent border spacing Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/printing/avoid-setting-header-offset-on-header-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)	2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)

3 * (C) 1997 Torben Weis (weis@kde.org)	3 * (C) 1997 Torben Weis (weis@kde.org)

4 * (C) 1998 Waldo Bastian (bastian@kde.org)	4 * (C) 1998 Waldo Bastian (bastian@kde.org)

5 * (C) 1999 Lars Knoll (knoll@kde.org)	5 * (C) 1999 Lars Knoll (knoll@kde.org)

6 * (C) 1999 Antti Koivisto (koivisto@kde.org)	6 * (C) 1999 Antti Koivisto (koivisto@kde.org)

7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights	7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights

8 * reserved.	8 * reserved.

9 *	9 *

10 * This library is free software; you can redistribute it and/or	10 * This library is free software; you can redistribute it and/or

(...skipping 100 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
111 LayoutTableRow* FirstRow() const;	111 LayoutTableRow* FirstRow() const;

112 LayoutTableRow* LastRow() const;	112 LayoutTableRow* LastRow() const;

113	113

114 void AddChild(LayoutObject* child,	114 void AddChild(LayoutObject* child,

115 LayoutObject* before_child = nullptr) override;	115 LayoutObject* before_child = nullptr) override;

116	116

117 int FirstLineBoxBaseline() const override;	117 int FirstLineBoxBaseline() const override;

118	118

119 void AddCell(LayoutTableCell, LayoutTableRow);	119 void AddCell(LayoutTableCell, LayoutTableRow);

120	120

	121 int VBorderSpacingBeforeFirstRow() const;

121 int CalcRowLogicalHeight();	122 int CalcRowLogicalHeight();

122 void LayoutRows();	123 void LayoutRows();

123 void ComputeOverflowFromCells();	124 void ComputeOverflowFromCells();

124 bool RecalcChildOverflowAfterStyleChange();	125 bool RecalcChildOverflowAfterStyleChange();

125	126

126 void MarkAllCellsWidthsDirtyAndOrNeedsLayout(LayoutTable::WhatToMarkAllCells);	127 void MarkAllCellsWidthsDirtyAndOrNeedsLayout(LayoutTable::WhatToMarkAllCells);

127	128

128 LayoutTable* Table() const { return ToLayoutTable(Parent()); }	129 LayoutTable* Table() const { return ToLayoutTable(Parent()); }

129	130

130 typedef Vector<LayoutTableCell*, 2> SpanningLayoutTableCells;	131 typedef Vector<LayoutTableCell*, 2> SpanningLayoutTableCells;

(...skipping 371 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
502	503

503 // Whether any cell spans multiple rows or cols.	504 // Whether any cell spans multiple rows or cols.

504 bool has_spanning_cells_;	505 bool has_spanning_cells_;

505 };	506 };

506	507

507 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableSection, IsTableSection());	508 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableSection, IsTableSection());

508	509

509 } // namespace blink	510 } // namespace blink

510	511

511 #endif // LayoutTableSection_h	512 #endif // LayoutTableSection_h

OLD	NEW