Issue 2803313003: Wrapper tracing Document::m_nodeLists leaks node lists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2803313003: Wrapper tracing Document::m_nodeLists leaks node lists

Created:
3 years, 8 months ago by keishi

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Wrapper tracing Document::m_nodeLists leaks node lists Document::m_nodeLists's WeakMembers are traced in traceWrapper, which retains HTMLCollection wrapper, which retains HTMLCollection, which means it doesn't get removed from Document::m_nodeLists. BUG=707544

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -24 lines)			Patch
	M	third_party/WebKit/Source/core/dom/Document.cpp	View		3 chunks	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

keishi

The CQ bit was checked by keishi@chromium.org to run a CQ dry run

3 years, 8 months ago (2017-04-08 00:51:42 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803313003/1

3 years, 8 months ago (2017-04-08 00:52:14 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 8 months ago (2017-04-08 02:20:35 UTC) #3

commit-bot: I haz the power

3 years, 8 months ago (2017-04-08 02:20:36 UTC) #4

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages