Create Bookmark Footnote desktop iOS promotion

ui/views/bubble/bubble_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_frame_view.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "build/build_config.h"
@@ skipping 390 matching lines @@
       new BoxLayout(BoxLayout::kVertical, content_margins_.left(),
                     content_margins_.top(), 0));
   footnote_container_->set_background(
       Background::CreateSolidBackground(kFootnoteBackgroundColor));
   footnote_container_->SetBorder(
       CreateSolidSidedBorder(1, 0, 0, 0, kFootnoteBorderColor));
   footnote_container_->AddChildView(view);
   AddChildView(footnote_container_);
 }
 
+void BubbleFrameView::RemoveFootnoteView() {

[sky, 2017/05/17 16:00:41]

Instead of an explicit function like this, override ViewHierarchyChanged() and
if the view is the single child of footnote_container_ then delete
footnote_container_. If you do this, it means you can just delete the
footnote_view (or remove it from its parent), and the right thing will happen.
Add test coverage of this.

[mrefaat, 2017/05/17 19:44:56]

I remember that we talked about that and you said its also acceptable to have an
explicit function to do the footnote remove, is there an advantage for the
viewHierarchyChanged change over having explicit function to do that ?

[sky, 2017/05/18 02:55:38]

Sorry if I mislead you. It's a similar argument to why you don't have to remove
a view from its parent before deleting it. To do otherwise is error prone. It's
a common expectation that if you remove/delete the necessary cleanup is just
done.

[mrefaat1, 2017/05/23 22:15:34]

Done.

+  if (!footnote_container_)
+    return;
+
+  RemoveChildView(footnote_container_);
+  footnote_container_->RemoveAllChildViews(true);
+  delete footnote_container_;
+  footnote_container_ = nullptr;
+}
+
 gfx::Rect BubbleFrameView::GetUpdatedWindowBounds(const gfx::Rect& anchor_rect,
                                                   const gfx::Size& client_size,
                                                   bool adjust_if_offscreen) {
   gfx::Size size(GetSizeForClientSize(client_size));
 
   const BubbleBorder::Arrow arrow = bubble_border_->arrow();
   if (adjust_if_offscreen && BubbleBorder::has_arrow(arrow)) {
     // Try to mirror the anchoring if the bubble does not fit on the screen.
     if (!bubble_border_->is_arrow_at_center(arrow)) {
       MirrorArrowIfOffScreen(true, anchor_rect, size);
@@ skipping 114 matching lines @@
 
   DialogDelegate* dialog_delegate =
       GetWidget()->widget_delegate()->AsDialogDelegate();
   if (dialog_delegate && dialog_delegate->ShouldSnapFrameWidth())
     size.set_width(LayoutProvider::Get()->GetSnappedDialogWidth(size.width()));
 
   return size;
 }
 
 }  // namespace views