Create Bookmark Footnote desktop iOS promotion

chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_CONTROLLER_H_
 #define CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_CONTROLLER_H_
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
 #include "chrome/browser/ui/desktop_ios_promotion/sms_service.h"
 
 namespace desktop_ios_promotion {
 enum class PromotionEntryPoint;
 enum class PromotionDismissalReason;
 }
 
 class DesktopIOSPromotionView;
 class Profile;
 class PrefService;
 
 // This class provides data to the Desktop to mobile promotion and control the
 // promotion actions.
 class DesktopIOSPromotionController {

[sky, 2017/05/17 16:00:41]

I'm having a hard time seeing why you want to share this class with the new
code. I say this because the two code paths, for the most part, seem completely
different. Why bother?

[mrefaat, 2017/05/17 19:44:56]

Both are promotions surfaces and need logging & and updating sync, the
difference is that footnote promotion first surface doesn't have send SMS
button, and the second surface shouldn't update Sync but it should log.

[sky, 2017/05/18 02:55:38]

How about refactoring the SMS code out so that this class only contains the
parts that are needed by both?

[mrefaat1, 2017/05/23 22:15:34]

Done.

[mrefaat, 2017/05/24 19:04:19]

Done.

  public:
   // Must be instantiated on the UI thread.
   DesktopIOSPromotionController(
       Profile* profile,
       DesktopIOSPromotionView* promotion_view,
       desktop_ios_promotion::PromotionEntryPoint entry_point);
   ~DesktopIOSPromotionController();
 
   // Returns the current promotion entry point.
   desktop_ios_promotion::PromotionEntryPoint entry_point() const {
     return entry_point_;
   }
 
   // Called by the view code when "Send SMS" button is clicked by the user.
   void OnSendSMSClicked();
 
   // Called by the view code when the promotion is ready to show.
   void OnPromotionShown();
 
+  // Called by the view when link to detailed promo is clicked by the user.
+  void OnLearnMoreLinkClicked();
+
   // Called by the view code when "No Thanks" button is clicked by the user.
   void OnNoThanksClicked();
 
   // Returns the Recovery phone number, returns empy string if the number is not
   // set.
   std::string GetUsersRecoveryPhoneNumber();
 
   // Used for testing.
   desktop_ios_promotion::PromotionDismissalReason dismissal_reason() const {
     return dismissal_reason_;
@@ skipping 21 matching lines @@
   DesktopIOSPromotionView* promotion_view_;
   // Track the action that is responsible for the promotion Dismissal.
   desktop_ios_promotion::PromotionDismissalReason dismissal_reason_;
 
   base::WeakPtrFactory<DesktopIOSPromotionController> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DesktopIOSPromotionController);
 };
 
 #endif  // CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_CONTROLLER_H_