Create Bookmark Footnote desktop iOS promotion

chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_controller.h"
 
 #include "base/bind.h"
 #include "base/metrics/field_trial_params.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/time/time.h"
@@ skipping 10 matching lines @@
     Profile* profile,
     DesktopIOSPromotionView* promotion_view,
     desktop_ios_promotion::PromotionEntryPoint entry_point)
     : profile_prefs_(profile->GetPrefs()),
       entry_point_(entry_point),
       sms_service_(SMSServiceFactory::GetForProfile(profile)),
       promotion_view_(promotion_view),
       dismissal_reason_(
           desktop_ios_promotion::PromotionDismissalReason::FOCUS_LOST),
       weak_ptr_factory_(this) {
-  sms_service_->QueryPhoneNumber(
-      base::Bind(&DesktopIOSPromotionController::OnGotPhoneNumber,
-                 weak_ptr_factory_.GetWeakPtr()));
+  if (entry_point_ !=
+      desktop_ios_promotion::PromotionEntryPoint::BOOKMARKS_FOOTNOTE) {
+    // Footnote promotion doesn't have a phone number.
+    sms_service_->QueryPhoneNumber(
+        base::Bind(&DesktopIOSPromotionController::OnGotPhoneNumber,
+                   weak_ptr_factory_.GetWeakPtr()));
+  }
 }
 
 DesktopIOSPromotionController::~DesktopIOSPromotionController() {
   desktop_ios_promotion::LogDismissalReason(dismissal_reason_, entry_point_);
 }
 
 void DesktopIOSPromotionController::OnSendSMSClicked() {
   sms_service_->SendSMS(desktop_ios_promotion::GetSMSID(),
                         base::Bind(&DesktopIOSPromotionController::OnSendSMS,
                                    weak_ptr_factory_.GetWeakPtr()));
 
   // Update Profile prefs.
   profile_prefs_->SetInteger(prefs::kIOSPromotionSMSEntryPoint,
                              static_cast<int>(entry_point_));
 
   // Update dismissal reason.
   dismissal_reason_ = desktop_ios_promotion::PromotionDismissalReason::SEND_SMS;
 }
 
 void DesktopIOSPromotionController::OnPromotionShown() {
+  // Update histograms.

[sky, 2017/05/17 16:00:41]

Remove this comment as it just documents what the next line does and that next
line is rather obvious.

[mrefaat, 2017/05/17 19:44:56]

Done.

+  UMA_HISTOGRAM_ENUMERATION(
+      "DesktopIOSPromotion.ImpressionFromEntryPoint",
+      static_cast<int>(entry_point_),
+      static_cast<int>(
+          desktop_ios_promotion::PromotionEntryPoint::ENTRY_POINT_MAX_VALUE));
+
+  if (entry_point_ ==
+      desktop_ios_promotion::PromotionEntryPoint::FOOTNOTE_FOLLOWUP_BUBBLE) {
+    // We don't want to update sync with the impression of this entrypoint.
+    return;
+  }
+
   // update the impressions count.
   PrefService* local_state = g_browser_process->local_state();
   int impressions = local_state->GetInteger(
       desktop_ios_promotion::kEntryPointLocalPrefs
           [static_cast<int>(entry_point_)][static_cast<int>(
               desktop_ios_promotion::EntryPointLocalPrefType::IMPRESSIONS)]);
   impressions++;
   local_state->SetInteger(
       desktop_ios_promotion::kEntryPointLocalPrefs
           [static_cast<int>(entry_point_)][static_cast<int>(
@@ skipping 14 matching lines @@
   double last_impression = base::Time::NowFromSystemTime().ToDoubleT();
   profile_prefs_->SetDouble(prefs::kIOSPromotionLastImpression,
                             last_impression);
 
   // If the variation id paramater is set on the finch experiement, set this
   // variation id to chrome sync pref to be accessed from iOS side.
   int variation_id = base::GetFieldTrialParamByFeatureAsInt(
       features::kDesktopIOSPromotion, "promo_variation_id", 0);
   if (variation_id)
     profile_prefs_->SetInteger(prefs::kIOSPromotionVariationId, variation_id);
+}
 
-  // Update histograms.
-  UMA_HISTOGRAM_ENUMERATION(
-      "DesktopIOSPromotion.ImpressionFromEntryPoint",
-      static_cast<int>(entry_point_),
-      static_cast<int>(
-          desktop_ios_promotion::PromotionEntryPoint::ENTRY_POINT_MAX_VALUE));
+void DesktopIOSPromotionController::OnLearnMoreLinkClicked() {
+  dismissal_reason_ =
+      desktop_ios_promotion::PromotionDismissalReason::LEARN_MORE;
 }
 
 void DesktopIOSPromotionController::OnNoThanksClicked() {
-  PrefService* local_state = g_browser_process->local_state();
-  local_state->SetBoolean(
-      desktop_ios_promotion::kEntryPointLocalPrefs
-          [static_cast<int>(entry_point_)][static_cast<int>(
-              desktop_ios_promotion::EntryPointLocalPrefType::DISMISSED)],
-      true);
+  if (entry_point_ !=
+      desktop_ios_promotion::PromotionEntryPoint::FOOTNOTE_FOLLOWUP_BUBBLE) {
+    PrefService* local_state = g_browser_process->local_state();
+    local_state->SetBoolean(
+        desktop_ios_promotion::kEntryPointLocalPrefs
+            [static_cast<int>(entry_point_)][static_cast<int>(
+                desktop_ios_promotion::EntryPointLocalPrefType::DISMISSED)],
+        true);
+  }
   dismissal_reason_ =
       desktop_ios_promotion::PromotionDismissalReason::NO_THANKS;
 }
 
 std::string DesktopIOSPromotionController::GetUsersRecoveryPhoneNumber() {
   return recovery_number_;
 }
 
 void DesktopIOSPromotionController::OnGotPhoneNumber(
     SMSService::Request* request,
     bool success,
     const std::string& number) {
+  DCHECK(promotion_view_);
   if (success) {
     recovery_number_ = desktop_ios_promotion::FormatPhoneNumber(number);
     promotion_view_->UpdateRecoveryPhoneLabel();
   }
   UMA_HISTOGRAM_BOOLEAN("DesktopIOSPromotion.QueryPhoneNumberSucceeded",
                         success);
 }
 
 void DesktopIOSPromotionController::OnSendSMS(SMSService::Request* request,
                                               bool success,
                                               const std::string& number) {
   UMA_HISTOGRAM_BOOLEAN("DesktopIOSPromotion.SendSMSSucceeded", success);
 }