Create Bookmark Footnote desktop iOS promotion

ui/views/bubble/bubble_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_frame_view.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "build/build_config.h"
@@ skipping 345 matching lines @@
 }
 
 void BubbleFrameView::OnNativeThemeChanged(const ui::NativeTheme* theme) {
   if (bubble_border_ && bubble_border_->use_theme_background_color()) {
     bubble_border_->set_background_color(GetNativeTheme()->
         GetSystemColor(ui::NativeTheme::kColorId_DialogBackground));
     SchedulePaint();
   }
 }
 
+void BubbleFrameView::ViewHierarchyChanged(
+    const ViewHierarchyChangedDetails& details) {
+  if (!details.is_add && details.parent == footnote_container_) {

[sky, 2017/05/24 00:03:35]

Combine these two ifs into 1. Also, add a comment as to why it's safe to null
out footnote_container_.

[mrefaat1, 2017/05/24 02:27:17]

Done.

+    if (footnote_container_->child_count() == 1 &&
+        details.child == footnote_container_->child_at(0)) {
+      footnote_container_->SetVisible(false);
+      footnote_container_ = nullptr;
+    }
+  }
+}
+
 void BubbleFrameView::OnPaint(gfx::Canvas* canvas) {
   OnPaintBackground(canvas);
   // Border comes after children.
 }
 
 void BubbleFrameView::PaintChildren(const ui::PaintContext& context) {
   NonClientFrameView::PaintChildren(context);
 
   ui::PaintCache paint_cache;
   ui::PaintRecorder recorder(context, size(), &paint_cache);
@@ skipping 25 matching lines @@
       new BoxLayout(BoxLayout::kVertical, content_margins_.left(),
                     content_margins_.top(), 0));
   footnote_container_->set_background(
       Background::CreateSolidBackground(kFootnoteBackgroundColor));
   footnote_container_->SetBorder(
       CreateSolidSidedBorder(1, 0, 0, 0, kFootnoteBorderColor));
   footnote_container_->AddChildView(view);
   AddChildView(footnote_container_);
 }
 
+void BubbleFrameView::RemoveFootnoteView() {
+  if (!footnote_container_)
+    return;
+
+  RemoveChildView(footnote_container_);
+  footnote_container_->RemoveAllChildViews(true);
+  delete footnote_container_;
+  footnote_container_ = nullptr;
+}
+
 gfx::Rect BubbleFrameView::GetUpdatedWindowBounds(const gfx::Rect& anchor_rect,
                                                   const gfx::Size& client_size,
                                                   bool adjust_if_offscreen) {
   gfx::Size size(GetSizeForClientSize(client_size));
 
   const BubbleBorder::Arrow arrow = bubble_border_->arrow();
   if (adjust_if_offscreen && BubbleBorder::has_arrow(arrow)) {
     // Try to mirror the anchoring if the bubble does not fit on the screen.
     if (!bubble_border_->is_arrow_at_center(arrow)) {
       MirrorArrowIfOffScreen(true, anchor_rect, size);
@@ skipping 114 matching lines @@
 
   DialogDelegate* dialog_delegate =
       GetWidget()->widget_delegate()->AsDialogDelegate();
   if (dialog_delegate && dialog_delegate->ShouldSnapFrameWidth())
     size.set_width(LayoutProvider::Get()->GetSnappedDialogWidth(size.width()));
 
   return size;
 }
 
 }  // namespace views