Create Bookmark Footnote desktop iOS promotion

chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
 
 #include <utility>
 
 #include "base/macros.h"
 #include "base/metrics/user_metrics.h"
@@ skipping 25 matching lines @@
 #include "ui/views/controls/link.h"
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/layout/layout_constants.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(OS_WIN)
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.h"
+#include "chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_footnote_view.h"
 #include "components/browser_sync/profile_sync_service.h"
 #endif
 
 using base::UserMetricsAction;
 using bookmarks::BookmarkModel;
 using bookmarks::BookmarkNode;
 using views::ColumnSet;
 using views::GridLayout;
 
 namespace {
@@ skipping 72 matching lines @@
   // |parent_combobox_| needs to be destroyed before |parent_model_| as it
   // uses |parent_model_| in its destructor.
   delete parent_combobox_;
 }
 
 void BookmarkBubbleView::WindowClosing() {
   // We have to reset |bubble_| here, not in our destructor, because we'll be
   // destroyed asynchronously and the shown state will be checked before then.
   DCHECK_EQ(bookmark_bubble_, this);
   bookmark_bubble_ = NULL;
+  is_showing_ios_promotion_ = false;
 
   if (observer_)
     observer_->OnBookmarkBubbleHidden();
 }
 
 bool BookmarkBubbleView::AcceleratorPressed(
     const ui::Accelerator& accelerator) {
   ui::KeyboardCode key_code = accelerator.key_code();
   if (key_code == ui::VKEY_RETURN) {
     HandleButtonPressed(close_button_);
@@ skipping 114 matching lines @@
 
 const char* BookmarkBubbleView::GetClassName() const {
   return "BookmarkBubbleView";
 }
 
 views::View* BookmarkBubbleView::GetInitiallyFocusedView() {
   return title_tf_;
 }
 
 views::View* BookmarkBubbleView::CreateFootnoteView() {
+  if (!is_showing_ios_promotion_ &&
+      IsIOSPromotionEligible(
+          desktop_ios_promotion::PromotionEntryPoint::BOOKMARKS_FOOTNOTE)) {
+    footnote_view_ = new DesktopIOSPromotionFootnoteView(profile_, this);
+    return footnote_view_;
+  }
+
   if (!SyncPromoUI::ShouldShowSyncPromo(profile_))
     return nullptr;
 
   base::RecordAction(
       base::UserMetricsAction("Signin_Impression_FromBookmarkBubble"));
 
-  return new BubbleSyncPromoView(delegate_.get(), IDS_BOOKMARK_SYNC_PROMO_LINK,
-                                 IDS_BOOKMARK_SYNC_PROMO_MESSAGE);
+  footnote_view_ =
+      new BubbleSyncPromoView(delegate_.get(), IDS_BOOKMARK_SYNC_PROMO_LINK,
+                              IDS_BOOKMARK_SYNC_PROMO_MESSAGE);
+  return footnote_view_;
 }
 
 BookmarkBubbleView::BookmarkBubbleView(
     views::View* anchor_view,
     bookmarks::BookmarkBubbleObserver* observer,
     std::unique_ptr<BubbleSyncPromoDelegate> delegate,
     Profile* profile,
     const GURL& url,
     bool newly_bookmarked)
     : LocationBarBubbleDelegateView(anchor_view, nullptr),
       observer_(observer),
       delegate_(std::move(delegate)),
       profile_(profile),
       url_(url),
       newly_bookmarked_(newly_bookmarked),
       parent_model_(BookmarkModelFactory::GetForBrowserContext(profile_),
                     BookmarkModelFactory::GetForBrowserContext(profile_)
                         ->GetMostRecentlyAddedUserNodeForURL(url)),
       remove_button_(nullptr),
       edit_button_(nullptr),
       close_button_(nullptr),
       title_tf_(nullptr),
       parent_combobox_(nullptr),
       ios_promo_view_(nullptr),
+      footnote_view_(nullptr),
       remove_bookmark_(false),
       apply_edits_(true),
       is_showing_ios_promotion_(false) {
   chrome::RecordDialogCreation(chrome::DialogIdentifier::BOOKMARK);
 }
 
 base::string16 BookmarkBubbleView::GetTitle() {
   BookmarkModel* bookmark_model =
       BookmarkModelFactory::GetForBrowserContext(profile_);
   const BookmarkNode* node =
@@ skipping 30 matching lines @@
     // Set this so we remove the bookmark after the window closes.
     remove_bookmark_ = true;
     apply_edits_ = false;
     GetWidget()->Close();
   } else if (sender == edit_button_) {
     base::RecordAction(UserMetricsAction("BookmarkBubble_Edit"));
     ShowEditor();
   } else {
     DCHECK_EQ(close_button_, sender);
 #if defined(OS_WIN)
-    PrefService* prefs = profile_->GetPrefs();
-    const browser_sync::ProfileSyncService* sync_service =
-        ProfileSyncServiceFactory::GetForProfile(profile_);
-    if (desktop_ios_promotion::IsEligibleForIOSPromotion(
-            prefs, sync_service,
+    if (IsIOSPromotionEligible(
             desktop_ios_promotion::PromotionEntryPoint::BOOKMARKS_BUBBLE)) {
-      ShowIOSPromotion();
+      ShowIOSPromotion(
+          desktop_ios_promotion::PromotionEntryPoint::BOOKMARKS_BUBBLE);
     } else {
       GetWidget()->Close();
     }
 #else
     GetWidget()->Close();
 #endif
   }
 }
 
 void BookmarkBubbleView::ShowEditor() {
@@ skipping 25 matching lines @@
     const base::string16 new_title = title_tf_->text();
     if (new_title != node->GetTitle()) {
       model->SetTitle(node, new_title);
       base::RecordAction(
           UserMetricsAction("BookmarkBubble_ChangeTitleInBubble"));
     }
     parent_model_.MaybeChangeParent(node, parent_combobox_->selected_index());
   }
 }
 
+void BookmarkBubbleView::OnIOSPromotionFootnoteLinkClicked() {
 #if defined(OS_WIN)
-void BookmarkBubbleView::ShowIOSPromotion() {
+  ShowIOSPromotion(
+      desktop_ios_promotion::PromotionEntryPoint::FOOTNOTE_FOLLOWUP_BUBBLE);
+#endif
+}
+
+#if defined(OS_WIN)
+
+bool BookmarkBubbleView::IsIOSPromotionEligible(
+    desktop_ios_promotion::PromotionEntryPoint entry_point) {
+  PrefService* prefs = profile_->GetPrefs();
+  const browser_sync::ProfileSyncService* sync_service =
+      ProfileSyncServiceFactory::GetForProfile(profile_);
+  return desktop_ios_promotion::IsEligibleForIOSPromotion(prefs, sync_service,
+                                                          entry_point);
+}
+
+void BookmarkBubbleView::ShowIOSPromotion(
+    desktop_ios_promotion::PromotionEntryPoint entry_point) {
   DCHECK(!is_showing_ios_promotion_);
   RemoveChildView(bookmark_details_view_.get());
+  if (footnote_view_) {

[sky, 2017/05/24 00:03:35]

You don't actually need this conditional (delete null does nothing).

[mrefaat1, 2017/05/24 02:27:17]

Done.

+    delete footnote_view_;
+    footnote_view_ = nullptr;
+  }
+
   is_showing_ios_promotion_ = true;
-  ios_promo_view_ = new DesktopIOSPromotionBubbleView(
-      profile_, desktop_ios_promotion::PromotionEntryPoint::BOOKMARKS_BUBBLE);
+  ios_promo_view_ = new DesktopIOSPromotionBubbleView(profile_, entry_point);
   AddChildView(ios_promo_view_);
   GetWidget()->UpdateWindowIcon();
   GetWidget()->UpdateWindowTitle();
   // Resize the bubble so it has the same width as the parent bubble.
   ios_promo_view_->UpdateBubbleHeight();
 }
 #endif