third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 2803243002: Use a ResizeObserver to determine default font-size for text tracks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2803243002: Use a ResizeObserver to determine default font-size for text tracks (Closed)

Patch Set: Update media/track/track-cue-rendering.html Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index f0b87749979238b2104643cf58d6ff82cfaca0f5..361a29b1ad3f4f5483fb75eaeb8ecbe0f5d560d2 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -3647,8 +3647,7 @@ TextTrackContainer& HTMLMediaElement::ensureTextTrackContainer() {

if (firstChild && firstChild->isTextTrackContainer())

return toTextTrackContainer(*firstChild);

- TextTrackContainer* textTrackContainer =

- TextTrackContainer::create(document());

+ TextTrackContainer* textTrackContainer = TextTrackContainer::create(*this);

// The text track container should be inserted before the media controls,

// so that they are rendered behind them.