Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn

Issue 2803223002: Create a Most Visited tile for ContentSuggestions (Closed)
Patch Set: Reviewable Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2017 The Chromium Authors. All rights reserved. 1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("cells") { 5 source_set("cells") {
6 sources = [ 6 sources = [
7 "content_suggestions_article_item.h", 7 "content_suggestions_article_item.h",
8 "content_suggestions_article_item.mm", 8 "content_suggestions_article_item.mm",
9 "content_suggestions_footer_item.h", 9 "content_suggestions_footer_item.h",
10 "content_suggestions_footer_item.mm", 10 "content_suggestions_footer_item.mm",
11 "content_suggestions_most_visited.h",
12 "content_suggestions_most_visited.mm",
13 "content_suggestions_most_visited_tile.h",
14 "content_suggestions_most_visited_tile.mm",
11 "content_suggestions_reading_list_item.h", 15 "content_suggestions_reading_list_item.h",
12 "content_suggestions_reading_list_item.mm", 16 "content_suggestions_reading_list_item.mm",
13 "content_suggestions_text_item.h", 17 "content_suggestions_text_item.h",
14 "content_suggestions_text_item.mm", 18 "content_suggestions_text_item.mm",
15 ] 19 ]
16 deps = [ 20 deps = [
17 "//base", 21 "//base",
18 "//ios/chrome/browser/ui", 22 "//ios/chrome/browser/ui",
19 "//ios/chrome/browser/ui/collection_view", 23 "//ios/chrome/browser/ui/collection_view",
20 "//ios/chrome/browser/ui/colors", 24 "//ios/chrome/browser/ui/colors",
21 "//ios/chrome/browser/ui/content_suggestions/identifier", 25 "//ios/chrome/browser/ui/content_suggestions/identifier",
22 "//ios/chrome/browser/ui/favicon:favicon_ui", 26 "//ios/chrome/browser/ui/favicon:favicon_ui",
23 "//ios/chrome/browser/ui/reading_list", 27 "//ios/chrome/browser/ui/reading_list",
24 "//ios/chrome/browser/ui/util", 28 "//ios/chrome/browser/ui/util",
25 "//ui/base", 29 "//ui/base",
26 "//url", 30 "//url",
27 ] 31 ]
28 configs += [ "//build/config/compiler:enable_arc" ] 32 configs += [ "//build/config/compiler:enable_arc" ]
29 } 33 }
30 34
31 source_set("unit_tests") { 35 source_set("unit_tests") {
32 testonly = true 36 testonly = true
33 sources = [ 37 sources = [
34 "content_suggestions_article_item_unittest.mm", 38 "content_suggestions_article_item_unittest.mm",
35 "content_suggestions_footer_item_unittest.mm", 39 "content_suggestions_footer_item_unittest.mm",
40 "content_suggestions_most_visited_tile_unittest.mm",
lpromero 2017/04/07 10:58:22 Can you add a simple CSMostVisited unittests file?
gambard 2017/04/07 14:47:21 Done.
36 ] 41 ]
37 deps = [ 42 deps = [
38 ":cells", 43 ":cells",
39 "//base", 44 "//base",
40 "//ios/chrome/browser/ui/collection_view", 45 "//ios/chrome/browser/ui/collection_view",
41 "//testing/gtest", 46 "//testing/gtest",
42 "//third_party/ocmock", 47 "//third_party/ocmock",
43 "//url", 48 "//url",
44 ] 49 ]
45 configs += [ "//build/config/compiler:enable_arc" ] 50 configs += [ "//build/config/compiler:enable_arc" ]
46 } 51 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698