Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Issue 2803143002: Support filling in baselines from other platforms in rebaseline-cl. (Closed)
Patch Set: Undo some changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
index a01849505d6596040df1996af137306394e2674a..7a205dd6d3467b7eb85d8040fadd7f5f945fd24a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
@@ -149,6 +149,7 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
'results_directory': None,
'verbose': False,
'trigger_jobs': False,
+ 'fill_missing': False,
}
options.update(kwargs)
return optparse.Values(dict(**options))
@@ -339,3 +340,20 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
'ERROR: Aborting: there are unstaged baselines:\n',
'ERROR: /mock-checkout/third_party/WebKit/LayoutTests/my-test-expected.txt\n',
])
+
+ def test_fill_in_missing_results(self):
+ test_baseline_set = TestBaselineSet(self.tool)
+ test_baseline_set.add('fast/dom/prototype-taco.html', Build('MOCK Try Linux', 100))
+ test_baseline_set.add('fast/dom/prototype-taco.html', Build('MOCK Try Win', 200))
+ self.command.fill_in_missing_results(test_baseline_set)
+ self.assertEqual(
+ test_baseline_set.build_port_pairs('fast/dom/prototype-taco.html'),
+ [
+ (Build(builder_name='MOCK Try Linux', build_number=100), 'test-linux-trusty'),
+ (Build(builder_name='MOCK Try Win', build_number=200), 'test-win-win7'),
+ (Build(builder_name='MOCK Try Linux', build_number=100), 'test-mac-mac10.11'),
+ ])
+ self.assertLog([
+ 'INFO: For fast/dom/prototype-taco.html:\n',
+ 'INFO: Using Build(builder_name=\'MOCK Try Linux\', build_number=100) to supply results for test-mac-mac10.11.\n',
+ ])

Powered by Google App Engine
This is Rietveld 408576698