Fix for parsing named factory constructors with Fasta.

Fix for parsing named factory constructors with Fasta.

R=paulberry@google.com, ahe@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/80a935bd767c35c15a4629c9d6c96e24572a398b

[Paul Berry, 2017-04-06 20:36:51]

lgtm assuming the call to toAnalyzerToken is reinstated.

https://codereview.chromium.org/2803113002/diff/1/pkg/analyzer/lib/src/fasta/...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/2803113002/diff/1/pkg/analyzer/lib/src/fasta/...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1572: factoryKeyword,
Analyzer and Fasta token types have been partially merged but not completely. 
So I don't think we should drop the call to toAnalyzerToken() yet (even though
it may not trigger any test failures right now).

[scheglov, 2017-04-06 21:11:38]

https://codereview.chromium.org/2803113002/diff/1/pkg/analyzer/lib/src/fasta/...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/2803113002/diff/1/pkg/analyzer/lib/src/fasta/...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1572: factoryKeyword,
On 2017/04/06 20:36:51, Paul Berry wrote:
> Analyzer and Fasta token types have been partially merged but not completely. 
> So I don't think we should drop the call to toAnalyzerToken() yet (even though
> it may not trigger any test failures right now).

Done.

[scheglov, 2017-04-06 21:12:03]

Description was changed from

==========
Fix for parsing named factory constructors with Fasta.

R=ahe@google.com, paulberry@google.com
BUG=
==========

to

==========
Fix for parsing named factory constructors with Fasta.

R=paulberry@google.com, ahe@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/80a935bd767c35c15a4629c9d6c96e24572a398b
==========

[scheglov, 2017-04-06 21:12:05]

Committed patchset #2 (id:20001) manually as
80a935bd767c35c15a4629c9d6c96e24572a398b (presubmit successful).

[ahe, 2017-04-07 10:45:47]

lgtm