third_party/WebKit/Source/platform/audio/HRTFElevation.cpp - Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/HRTFElevation.cpp

Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (Closed)

Patch Set: Removing DCHECK_IS_ON from FFTFrameOpenMAXDLAndroid.cpp Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/audio/HRTFElevation.cpp

diff --git a/third_party/WebKit/Source/platform/audio/HRTFElevation.cpp b/third_party/WebKit/Source/platform/audio/HRTFElevation.cpp

index bf0df80f75752501e991dbe0593024a5f7062ca5..af42a3ef013b2a2afd990b477a765e41d3201455 100644

--- a/third_party/WebKit/Source/platform/audio/HRTFElevation.cpp

+++ b/third_party/WebKit/Source/platform/audio/HRTFElevation.cpp

@@ -309,11 +309,13 @@ std::unique_ptr<HRTFElevation> HRTFElevation::createByInterpolatingSlices(

HRTFElevation* hrtfElevation2,

float x,

float sampleRate) {

- ASSERT(hrtfElevation1 && hrtfElevation2);

+ DCHECK(hrtfElevation1);

+ DCHECK(hrtfElevation2);

if (!hrtfElevation1 || !hrtfElevation2)

return nullptr;

- ASSERT(x >= 0.0 && x < 1.0);

+ DCHECK_GE(x, 0.0);

+ DCHECK_LT(x, 1.0);

std::unique_ptr<HRTFKernelList> kernelListL =

WTF::makeUnique<HRTFKernelList>(NumberOfTotalAzimuths);