Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp

Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (Closed)
Patch Set: Removing DCHECK_IS_ON from FFTFrameOpenMAXDLAndroid.cpp Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp
diff --git a/third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp b/third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp
index 2630b916d21751f274356556cc2bc181eb1e7094..4324c5c872f30b9c49e15f10b8194d24bae7c19e 100644
--- a/third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp
+++ b/third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp
@@ -45,7 +45,8 @@ AudioDelayDSPKernel::AudioDelayDSPKernel(double maxDelayTime, float sampleRate)
m_maxDelayTime(maxDelayTime),
m_writeIndex(0),
m_firstTime(true) {
- ASSERT(maxDelayTime > 0.0 && !std::isnan(maxDelayTime));
+ DCHECK_GT(maxDelayTime, 0.0);
+ DCHECK(!std::isnan(maxDelayTime));
if (maxDelayTime <= 0.0 || std::isnan(maxDelayTime))
return;
@@ -91,7 +92,8 @@ void AudioDelayDSPKernel::process(const float* source,
if (!bufferLength)
return;
- ASSERT(source && destination);
+ DCHECK(source);
+ DCHECK(destination);
if (!source || !destination)
return;

Powered by Google App Engine
This is Rietveld 408576698