Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp

Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 // Normal constructor: allocates for a given fftSize. 51 // Normal constructor: allocates for a given fftSize.
52 FFTFrame::FFTFrame(unsigned fftSize) 52 FFTFrame::FFTFrame(unsigned fftSize)
53 : m_FFTSize(fftSize), 53 : m_FFTSize(fftSize),
54 m_log2FFTSize(static_cast<unsigned>(log2(fftSize))), 54 m_log2FFTSize(static_cast<unsigned>(log2(fftSize))),
55 m_realData(fftSize / 2), 55 m_realData(fftSize / 2),
56 m_imagData(fftSize / 2), 56 m_imagData(fftSize / 2),
57 m_forwardContext(nullptr), 57 m_forwardContext(nullptr),
58 m_inverseContext(nullptr), 58 m_inverseContext(nullptr),
59 m_complexData(fftSize) { 59 m_complexData(fftSize) {
60 // We only allow power of two. 60 // We only allow power of two.
61 ASSERT(1UL << m_log2FFTSize == m_FFTSize); 61 DCHECK_EQ(1UL << m_log2FFTSize, m_FFTSize);
62 62
63 m_forwardContext = contextForSize(fftSize, DFT_R2C); 63 m_forwardContext = contextForSize(fftSize, DFT_R2C);
64 m_inverseContext = contextForSize(fftSize, IDFT_C2R); 64 m_inverseContext = contextForSize(fftSize, IDFT_C2R);
65 } 65 }
66 66
67 // Creates a blank/empty frame (interpolate() must later be called). 67 // Creates a blank/empty frame (interpolate() must later be called).
68 FFTFrame::FFTFrame() 68 FFTFrame::FFTFrame()
69 : m_FFTSize(0), 69 : m_FFTSize(0),
70 m_log2FFTSize(0), 70 m_log2FFTSize(0),
71 m_forwardContext(nullptr), 71 m_forwardContext(nullptr),
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 return const_cast<float*>(m_complexData.data()); 150 return const_cast<float*>(m_complexData.data());
151 } 151 }
152 152
153 RDFTContext* FFTFrame::contextForSize(unsigned fftSize, int trans) { 153 RDFTContext* FFTFrame::contextForSize(unsigned fftSize, int trans) {
154 // FIXME: This is non-optimal. Ideally, we'd like to share the contexts for 154 // FIXME: This is non-optimal. Ideally, we'd like to share the contexts for
155 // FFTFrames of the same size. But FFmpeg's RDFT uses a scratch buffer 155 // FFTFrames of the same size. But FFmpeg's RDFT uses a scratch buffer
156 // inside the context and so they are not thread-safe. We could improve this 156 // inside the context and so they are not thread-safe. We could improve this
157 // by sharing the FFTFrames on a per-thread basis. 157 // by sharing the FFTFrames on a per-thread basis.
158 DCHECK(fftSize); 158 DCHECK(fftSize);
159 int pow2size = static_cast<int>(log2(fftSize)); 159 int pow2size = static_cast<int>(log2(fftSize));
160 ASSERT(pow2size < kMaxFFTPow2Size); 160 DCHECK_LT(pow2size, kMaxFFTPow2Size);
161 161
162 RDFTContext* context = av_rdft_init(pow2size, (RDFTransformType)trans); 162 RDFTContext* context = av_rdft_init(pow2size, (RDFTransformType)trans);
163 return context; 163 return context;
164 } 164 }
165 165
166 } // namespace blink 166 } // namespace blink
167 167
168 #endif // USE(WEBAUDIO_FFMPEG) 168 #endif // USE(WEBAUDIO_FFMPEG)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698