telemetry/telemetry/internal/backends/chrome/oobe.py - Issue 2803043002: Fix flaky NPE in oobe.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/oobe.py

Issue 2803043002: Fix flaky NPE in oobe.js. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/internal/backends/chrome/oobe.py

diff --git a/telemetry/telemetry/internal/backends/chrome/oobe.py b/telemetry/telemetry/internal/backends/chrome/oobe.py

index fff4278ca022f3d10ab912f9bbe33f9b21c90eae..a39b6472bcd3bbee1679086f96ef6038856db5c7 100644

--- a/telemetry/telemetry/internal/backends/chrome/oobe.py

+++ b/telemetry/telemetry/internal/backends/chrome/oobe.py

@@ -37,7 +37,8 @@ class Oobe(web_contents.WebContents):

def _ExecuteOobeApi(self, api, *args):

logging.info('Invoking %s' % api)

- self.WaitForJavaScriptCondition("typeof Oobe == 'function'", timeout=120)

+ self.WaitForJavaScriptCondition(

+ "typeof Oobe == 'function' && Oobe.readyForTesting", timeout=120)

if self.EvaluateJavaScript(

"typeof {{ @api }} == 'undefined'", api=api):

« no previous file with comments | « no previous file | no next file » | no next file with comments »