Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

Issue 2803013005: Deduplicating compositing scrollingCoordinator helper (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
index c146c8bbb7cbf6abdb39ed4929975891d8bbe732..6d2527a217e500036793e8898ff3ea746130b291 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
@@ -270,11 +270,6 @@ void CompositingLayerAssigner::updateSquashingAssignment(
}
}
-static ScrollingCoordinator* scrollingCoordinatorFromLayer(PaintLayer& layer) {
- Page* page = layer.layoutObject().frame()->page();
- return (!page) ? nullptr : page->scrollingCoordinator();
-}
-
void CompositingLayerAssigner::assignLayersToBackingsInternal(
PaintLayer* layer,
SquashingState& squashingState,
@@ -299,7 +294,7 @@ void CompositingLayerAssigner::assignLayersToBackingsInternal(
layersNeedingPaintInvalidation.push_back(layer);
m_layersChanged = true;
if (ScrollingCoordinator* scrollingCoordinator =
- scrollingCoordinatorFromLayer(*layer)) {
+ CompositedLayerMapping::scrollingCoordinatorFromLayer(*layer)) {
if (layer->layoutObject().style()->hasViewportConstrainedPosition()) {
scrollingCoordinator->frameViewFixedObjectsDidChange(
layer->layoutObject().view()->frameView());

Powered by Google App Engine
This is Rietveld 408576698