runtime/vm/profiler_test.cc - Issue 2803013004: Mark optimized code for the crash handler and disassembler output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/profiler_test.cc

Issue 2803013004: Mark optimized code for the crash handler and disassembler output. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/profiler_test.cc

diff --git a/runtime/vm/profiler_test.cc b/runtime/vm/profiler_test.cc

index ccada84dc3b8c8812b8727ed8832a4cabac97a60..39d097e5e6144327fb40b92cfbcf5c5b03a0478c 100644

--- a/runtime/vm/profiler_test.cc

+++ b/runtime/vm/profiler_test.cc

@@ -1535,7 +1535,7 @@ TEST_CASE(Profiler_FunctionInline) {

EXPECT_STREQ("[Stub] Allocate A", walker.CurrentName());

EXPECT_EQ(50000, walker.CurrentExclusiveTicks());

EXPECT(walker.Down());

- EXPECT_STREQ("B.boo", walker.CurrentName());

+ EXPECT_STREQ("*B.boo", walker.CurrentName());

EXPECT_EQ(1, walker.SiblingCount());

EXPECT_EQ(50000, walker.CurrentNodeTickCount());

EXPECT_EQ(50000, walker.CurrentInclusiveTicks());

@@ -1555,7 +1555,7 @@ TEST_CASE(Profiler_FunctionInline) {

EXPECT_EQ(50000, walker.CurrentInclusiveTicks());

EXPECT_EQ(0, walker.CurrentExclusiveTicks());

EXPECT(walker.Down());

- EXPECT_STREQ("B.boo", walker.CurrentName());

+ EXPECT_STREQ("*B.boo", walker.CurrentName());

EXPECT_EQ(1, walker.SiblingCount());

EXPECT_EQ(50000, walker.CurrentNodeTickCount());

EXPECT_EQ(50000, walker.CurrentInclusiveTicks());

@@ -1655,7 +1655,7 @@ TEST_CASE(Profiler_FunctionInline) {

EXPECT(walker.Down());

EXPECT_STREQ("[Unoptimized Code]", walker.CurrentName());

EXPECT(walker.Down());

- EXPECT_STREQ("B.boo", walker.CurrentName());

+ EXPECT_STREQ("*B.boo", walker.CurrentName());

EXPECT(walker.Down());

EXPECT_STREQ("[Optimized Code]", walker.CurrentName());

EXPECT(walker.Down());

@@ -1672,7 +1672,7 @@ TEST_CASE(Profiler_FunctionInline) {

EXPECT(walker.Down());

EXPECT_STREQ("[Optimized Code]", walker.CurrentName());

EXPECT(walker.Down());

- EXPECT_STREQ("B.boo", walker.CurrentName());

+ EXPECT_STREQ("*B.boo", walker.CurrentName());

EXPECT(walker.Down());

EXPECT_STREQ("[Unoptimized Code]", walker.CurrentName());

EXPECT(walker.Down());

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »