Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2802973005: Migrate async tests to strong (Closed)

Created:
3 years, 8 months ago by vsm
Modified:
3 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate async tests to strong No modifications to the actual tests R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/1975c8431a85384261e7be85b37a1637a879b760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13162 lines, -0 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +50 lines, -0 lines 0 comments Download
M pkg/dev_compiler/test/codegen_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A tests/lib_strong/async/async_await_sync_completer_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A tests/lib_strong/async/async_await_zones_test.dart View 1 chunk +142 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors.dart View 1 chunk +57 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors11_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors12_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors13_test.dart View 1 chunk +90 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors14_test.dart View 1 chunk +47 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors15_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors16_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors17_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors18_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors19_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors20_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors21_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors22_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors23_test.dart View 1 chunk +69 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors24_test.dart View 1 chunk +69 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors25_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors26_test.dart View 1 chunk +64 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors27_test.dart View 1 chunk +71 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors28_test.dart View 1 chunk +44 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors2_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors3_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors4_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors5_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors6_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors7_test.dart View 1 chunk +52 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors8_test.dart View 1 chunk +63 lines, -0 lines 0 comments Download
A tests/lib_strong/async/catch_errors_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A tests/lib_strong/async/dart2js_uncaught_error_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download
A tests/lib_strong/async/event_helper.dart View 1 chunk +182 lines, -0 lines 0 comments Download
A tests/lib_strong/async/first_regression_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_constructor2_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_constructor_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_delayed_error_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_microtask_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_or_bad_type_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_or_non_strong_test.dart View 1 chunk +118 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_or_only_in_async_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_or_strong_test.dart View 1 chunk +126 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_test.dart View 1 chunk +1240 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_timeout_test.dart View 1 chunk +198 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_value_chain2_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_value_chain3_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_value_chain4_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A tests/lib_strong/async/future_value_chain_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A tests/lib_strong/async/futures_test.dart View 1 chunk +262 lines, -0 lines 0 comments Download
A tests/lib_strong/async/intercept_print1_test.dart View 1 chunk +44 lines, -0 lines 0 comments Download
A tests/lib_strong/async/intercept_schedule_microtask1_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A tests/lib_strong/async/intercept_schedule_microtask2_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download
A tests/lib_strong/async/intercept_schedule_microtask3_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A tests/lib_strong/async/intercept_schedule_microtask4_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
A tests/lib_strong/async/intercept_schedule_microtask5_test.dart View 1 chunk +54 lines, -0 lines 0 comments Download
A tests/lib_strong/async/intercept_schedule_microtask6_test.dart View 1 chunk +54 lines, -0 lines 0 comments Download
A tests/lib_strong/async/multiple_timer_test.dart View 1 chunk +74 lines, -0 lines 0 comments Download
A tests/lib_strong/async/print_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A tests/lib_strong/async/run_zoned1_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A tests/lib_strong/async/run_zoned4_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A tests/lib_strong/async/run_zoned5_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/lib_strong/async/run_zoned6_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/lib_strong/async/run_zoned7_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A tests/lib_strong/async/run_zoned8_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A tests/lib_strong/async/run_zoned9_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A tests/lib_strong/async/schedule_microtask2_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
A tests/lib_strong/async/schedule_microtask3_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A tests/lib_strong/async/schedule_microtask5_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A tests/lib_strong/async/schedule_microtask_test.dart View 1 chunk +99 lines, -0 lines 0 comments Download
A tests/lib_strong/async/slow_consumer2_test.dart View 1 chunk +124 lines, -0 lines 0 comments Download
A tests/lib_strong/async/slow_consumer3_test.dart View 1 chunk +94 lines, -0 lines 0 comments Download
A tests/lib_strong/async/slow_consumer_test.dart View 1 chunk +127 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace01_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace02_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace03_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace04_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace05_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace06_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace07_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace08_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace09_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace10_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace11_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace12_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace13_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace14_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace15_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace16_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace17_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace18_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace19_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace20_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace21_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace22_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace23_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace24_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stack_trace25_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_controller_async_test.dart View 1 chunk +771 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_controller_test.dart View 1 chunk +959 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_empty_test.dart View 1 chunk +63 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_event_transformed_test.dart View 1 chunk +313 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_first_where_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_from_futures_test.dart View 1 chunk +130 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_from_iterable_test.dart View 1 chunk +151 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_iterator_double_cancel_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_iterator_test.dart View 1 chunk +95 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_join_test.dart View 1 chunk +75 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_last_where_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_listen_zone_test.dart View 1 chunk +148 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_periodic2_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_periodic3_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_periodic4_test.dart View 1 chunk +50 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_periodic5_test.dart View 1 chunk +44 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_periodic6_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_periodic_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_single_test.dart View 1 chunk +51 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_single_to_multi_subscriber_test.dart View 1 chunk +52 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_state_helper.dart View 1 chunk +589 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_state_nonzero_timer_test.dart View 1 chunk +102 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_state_test.dart View 1 chunk +165 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_subscription_as_future_test.dart View 1 chunk +126 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_subscription_cancel_test.dart View 1 chunk +322 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_take_test.dart View 1 chunk +63 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_timeout_test.dart View 1 chunk +182 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_transform_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_transformation_broadcast_test.dart View 1 chunk +362 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_transformer_from_handlers_test.dart View 1 chunk +67 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_transformer_test.dart View 1 chunk +87 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_type_test.dart View 1 chunk +66 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_view_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A tests/lib_strong/async/stream_zones_test.dart View 1 chunk +187 lines, -0 lines 0 comments Download
A tests/lib_strong/async/timer_cancel1_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/lib_strong/async/timer_cancel2_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
A tests/lib_strong/async/timer_cancel_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A tests/lib_strong/async/timer_isActive_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A tests/lib_strong/async/timer_not_available_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/lib_strong/async/timer_regress22626_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
A tests/lib_strong/async/timer_repeat_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A tests/lib_strong/async/timer_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A tests/lib_strong/async/wait_for_cancel_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_bind_callback_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_bind_callback_unary_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_bind_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_create_periodic_timer_test.dart View 1 chunk +54 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_create_timer2_test.dart View 1 chunk +44 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_create_timer_test.dart View 1 chunk +44 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_debug_test.dart View 1 chunk +134 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_empty_description2_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_empty_description_test.dart View 1 chunk +78 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_error_callback_test.dart View 1 chunk +327 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_fork_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_future_schedule_microtask_test.dart View 1 chunk +65 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_register_callback_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_register_callback_unary_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_root_bind_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_run_guarded_test.dart View 1 chunk +79 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_run_test.dart View 1 chunk +86 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_run_unary_test.dart View 1 chunk +65 lines, -0 lines 0 comments Download
A tests/lib_strong/async/zone_value_test.dart View 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 8 months ago (2017-04-07 16:41:43 UTC) #3
Bob Nystrom
lgtm
3 years, 8 months ago (2017-04-07 17:17:41 UTC) #4
vsm
3 years, 8 months ago (2017-04-07 19:46:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1975c8431a85384261e7be85b37a1637a879b760.

Powered by Google App Engine
This is Rietveld 408576698