Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 280293002: apply localmatrix in pre-order, to match other shaders (Closed)

Created:
6 years, 7 months ago by reed1
Modified:
6 years, 7 months ago
Reviewers:
sugoi1, sugoi
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

apply localmatrix in pre-order, to match other shaders BUG=skia: Committed: https://code.google.com/p/skia/source/detail?r=14699

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
no GMs were harmed in this CL
6 years, 7 months ago (2014-05-12 15:39:12 UTC) #1
sugoi
On 2014/05/12 15:39:12, reed1 wrote: > no GMs were harmed in this CL I'll do ...
6 years, 7 months ago (2014-05-12 15:42:43 UTC) #2
reed1
On 2014/05/12 15:42:43, sugoi wrote: > On 2014/05/12 15:39:12, reed1 wrote: > > no GMs ...
6 years, 7 months ago (2014-05-12 15:45:20 UTC) #3
reed1
fixes perlinnoise_localmatrix gm ptal
6 years, 7 months ago (2014-05-12 17:20:33 UTC) #4
sugoi1
On 2014/05/12 17:20:33, reed1 wrote: > fixes perlinnoise_localmatrix gm > > ptal Seems fine in ...
6 years, 7 months ago (2014-05-12 17:29:44 UTC) #5
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-12 17:54:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/280293002/20001
6 years, 7 months ago (2014-05-12 17:54:35 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-12 17:54:36 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-12 17:54:37 UTC) #9
reed1
6 years, 7 months ago (2014-05-12 18:12:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r14699.

Powered by Google App Engine
This is Rietveld 408576698