Implementation of a full screen app list and re-alphabetized switches

ui/app_list/views/app_list_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_view.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/macros.h"
@@ skipping 106 matching lines @@
   bool GetHitTestMask(aura::Window* window, gfx::Path* mask) const override {
     mask->addRect(gfx::RectToSkRect(search_box_->GetContentsBounds()));
     return true;
   }
 
   views::View* search_box_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchBoxWindowTargeter);
 };
 
+// Checks to see if the fullscreen app list has been enabled via cmd line switch

[vadimt, 2017/04/13 21:48:34]

add '.'

[newcomer, 2017/04/18 21:12:33]

Done.

+bool IsFullscreenAppListEnabled() {
+  return base::CommandLine::ForCurrentProcess()->HasSwitch(
+                     switches::kEnableFullscreenAppList);
+                     }
+
 }  // namespace
 
 // An animation observer to hide the view at the end of the animation.
 class HideViewAnimationObserver : public ui::ImplicitAnimationObserver {
  public:
   HideViewAnimationObserver()
       : frame_(NULL),
         target_(NULL) {
   }
 
@@ skipping 46 matching lines @@
   delegate_->GetSpeechUI()->AddObserver(this);
 }
 
 AppListView::~AppListView() {
   delegate_->GetSpeechUI()->RemoveObserver(this);
   animation_observer_.reset();
   // Remove child views first to ensure no remaining dependencies on delegate_.
   RemoveAllChildViews(true);
 }
 
+void AppListView::Initialize(gfx::NativeView parent,
+                                   int initial_apps_page,
+                                   const gfx::Point &center_of_display_window,
+                                   const gfx::Rect display_work_area_bounds) {
+  base::Time start_time = base::Time::Now();
+
+  InitContents(parent, initial_apps_page);
+  AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE));
+
+  if (IsFullscreenAppListEnabled()) {
+    set_color(kContentsBackgroundColor);
+    views::Widget *widget = new views::Widget;
+    views::Widget::InitParams app_list_overlay_view_params(
+        views::Widget::InitParams::TYPE_WINDOW_FRAMELESS);
+
+    app_list_overlay_view_params.parent = parent;
+    app_list_overlay_view_params.delegate = this;
+
+    widget->Init(app_list_overlay_view_params);
+    widget->SetBounds(display_work_area_bounds);
+    widget->GetLayer()->SetFillsBoundsOpaquely(false);
+    widget->GetLayer()->SetBackgroundBlur(10);
+
+    InitChildWidgets();
+    overlay_view_ = new AppListOverlayView(0 /* no corners */);
+    AddChildView(overlay_view_);

[vadimt, 2017/04/13 21:48:34]

Would it be possible to move this out of 'if'?

[newcomer, 2017/04/18 21:12:33]

I refactored this, and we talked about duplicated code offline.

+
+  } else {
+    set_margins(gfx::Insets());
+    set_parent_window(parent);
+    set_close_on_deactivate(false);
+    set_shadow(views::BubbleBorder::NO_ASSETS);
+    set_color(kContentsBackgroundColor);
+
+    // This creates the app list widget. (Before this, child widgets cannot be
+    // created.)
+    views::BubbleDialogDelegateView::CreateBubble(this);
+
+    SetBubbleArrow(views::BubbleBorder::FLOAT);
+    // We can now create the internal widgets.
+
+    InitChildWidgets();
+    aura::Window *window = GetWidget()->GetNativeWindow();
+    window->SetEventTargeter(
+        base::MakeUnique<views::BubbleWindowTargeter>(this));
+
+    const int kOverlayCornerRadius =
+        GetBubbleFrameView()->bubble_border()->GetBorderCornerRadius();
+    overlay_view_ = new AppListOverlayView(kOverlayCornerRadius);
+    overlay_view_->SetBoundsRect(GetContentsBounds());
+    AddChildView(overlay_view_);
+    SetAnchorPoint(center_of_display_window);
+  }
+
+  if (delegate_)
+    delegate_->ViewInitialized();
+
+  UMA_HISTOGRAM_TIMES("Apps.AppListCreationTime",
+                      base::Time::Now() - start_time);
+}
+
 void AppListView::InitAsBubble(gfx::NativeView parent, int initial_apps_page) {
   base::Time start_time = base::Time::Now();
 
   InitContents(parent, initial_apps_page);
 
   AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE));
   set_margins(gfx::Insets());
   set_parent_window(parent);
   set_close_on_deactivate(false);
   set_shadow(views::BubbleBorder::NO_ASSETS);
@@ skipping 94 matching lines @@
 }
 
 void AppListView::OnPaint(gfx::Canvas* canvas) {
   views::BubbleDialogDelegateView::OnPaint(canvas);
   if (!next_paint_callback_.is_null()) {
     next_paint_callback_.Run();
     next_paint_callback_.Reset();
   }
 }
 
+const char* AppListView::GetClassName() const {
+  return "AppListView";
+}
+
 bool AppListView::ShouldHandleSystemCommands() const {
   return true;
 }
 
 bool AppListView::ShouldDescendIntoChildForEventHandling(
     gfx::NativeView child,
     const gfx::Point& location) {
   // While on the start page, don't descend into the custom launcher page. Since
   // the only valid action is to open it.
   ContentsView* contents_view = app_list_main_view_->contents_view();
@@ skipping 19 matching lines @@
   // crbug.com/441028 are fixed.
   tracked_objects::ScopedTracker tracking_profile(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "440224, 441028 AppListView::InitContents"));
 
   app_list_main_view_ = new AppListMainView(delegate_);
   AddChildView(app_list_main_view_);
   app_list_main_view_->SetPaintToLayer();
   app_list_main_view_->layer()->SetFillsBoundsOpaquely(false);
   app_list_main_view_->layer()->SetMasksToBounds(true);
-
   // This will be added to the |search_box_widget_| after the app list widget is
   // initialized.
   search_box_view_ = new SearchBoxView(app_list_main_view_, delegate_);
   search_box_view_->SetPaintToLayer();
   search_box_view_->layer()->SetFillsBoundsOpaquely(false);
   search_box_view_->layer()->SetMasksToBounds(true);
 
   // TODO(vadimt): Remove ScopedTracker below once crbug.com/440224 and
   // crbug.com/441028 are fixed.
   tracked_objects::ScopedTracker tracking_profile1(
@@ skipping 210 matching lines @@
     app_list_main_view_->SetVisible(true);
     // Refocus the search box. However, if the app list widget does not have
     // focus, it means another window has already taken focus, and we *must not*
     // focus the search box (or we would steal focus back into the app list).
     if (GetWidget()->IsActive())
       search_box_view_->search_box()->RequestFocus();
   }
 }
 
 }  // namespace app_list