Implementation of a full screen app list and re-alphabetized switches

ui/app_list/app_list_switches.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/app_list_switches.h"
 
 #include "base/command_line.h"
 #include "build/build_config.h"
 
 namespace app_list {
 namespace switches {
 
 // If empty, search answers in the app app list are disabled, otherwise the URL
 // of the answer server.
 const char kAnswerServerUrl[] = "answer-server-url";
 
 // Specifies the chrome-extension:// URL for the contents of an additional page
 // added to the app launcher.
 const char kCustomLauncherPage[] = "custom-launcher-page";
 
 // If set, the app list will not be dismissed when it loses focus. This is
 // useful when testing the app list or a custom launcher page. It can still be
 // dismissed via the other methods (like the Esc key).
 const char kDisableAppListDismissOnBlur[] = "disable-app-list-dismiss-on-blur";
 
 // If set, the app list will be enabled as if enabled from CWS.
 const char kEnableAppList[] = "enable-app-list";
 
+// Enables the fullscreen app list.
+extern const char kEnableFullscreenAppList[] = "enable-fullscreen-app-list";
+
 // Enable/disable syncing of the app list independent of extensions.
 const char kEnableSyncAppList[] = "enable-sync-app-list";
 const char kDisableSyncAppList[] = "disable-sync-app-list";
 
 // Enable/disable drive search in chrome launcher.
 const char kEnableDriveSearchInChromeLauncher[] =
     "enable-drive-search-in-app-launcher";
 const char kDisableDriveSearchInChromeLauncher[] =
     "disable-drive-search-in-app-launcher";
 
@@ skipping 41 matching lines @@
 
 std::string AnswerServerUrl() {
   return base::CommandLine::ForCurrentProcess()->GetSwitchValueNative(
       kAnswerServerUrl);
 }
 
 bool IsAnswerCardEnabled() {
   return !AnswerServerUrl().empty();
 }
 
+void SetFullscreenAppListSwitch() {

[sky, 2017/04/21 21:02:38]

Is there a reason you have this here rather than in the test, which is the only
place that uses it?

[newcomer, 2017/04/21 22:44:15]

My reason is that usually setters/getters are near each other. However I see why
it could also live in the unit test. Which one do you prefer? This function
won't be around for very long regardless.

[sky, 2017/04/21 23:05:40]

As this code should only be used in tests, not production, putting it in the
test is the way to go.

[newcomer, 2017/04/25 00:16:00]

Done.

+  base::CommandLine::ForCurrentProcess()->AppendSwitch(
+      kEnableFullscreenAppList);
+}
+
+bool IsFullscreenAppListEnabled() {
+  return base::CommandLine::ForCurrentProcess()->HasSwitch(
+      kEnableFullscreenAppList);
+}
+
 }  // namespace switches
 }  // namespace app_list