Implementation of a full screen app list and re-alphabetized switches

ui/app_list/views/app_list_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_APP_LIST_VIEWS_APP_LIST_VIEW_H_
 #define UI_APP_LIST_VIEWS_APP_LIST_VIEW_H_
 
 #include <memory>
 
 #include "base/callback.h"
@@ skipping 20 matching lines @@
 
 // AppListView is the top-level view and controller of app list UI. It creates
 // and hosts a AppsGridView and passes AppListModel to it for display.
 class APP_LIST_EXPORT AppListView : public views::BubbleDialogDelegateView,
                                     public SpeechUIModelObserver {
  public:
   // Does not take ownership of |delegate|.
   explicit AppListView(AppListViewDelegate* delegate);
   ~AppListView() override;
 
-  // Initializes the widget.
+  // Helper function for Initialize, used when there is a flag.

[vadimt, 2017/04/19 00:57:15]

We use 'helper' in class names, not method names.
Please rename, and change comments from "where it's used from" to "what it
does".

[newcomer, 2017/04/20 19:59:02]

Done.

+  void InitializeFullscreenHelper(gfx::NativeView parent,

[sky, 2017/04/19 15:18:51]

Document what the parameters meant.

[newcomer, 2017/04/20 19:59:02]

Done.

+                                  int initial_apps_page,
+                                  const gfx::Rect display_work_area_bounds);

[sky, 2017/04/19 15:18:51]

const gfx::Rect& here and 53.

[newcomer, 2017/04/20 19:59:02]

Done.

+
+  // Helper function for Initialize, used when there is no flag.
+  void InitializeBubbleHelper(gfx::NativeView parent, int initial_apps_page);

[sky, 2017/04/19 15:18:51]

Why do you need the InitializeHelper functions to be public? Shouldn't callers
only call Initialize? Also, why do you need InitAsBubble? Can there be *one*
public init function? It can take an enum indicating the mode.

[newcomer, 2017/04/20 19:59:02]

Thanks, I made the helper functions (now no longer renamed *Helper after vadimt@
's note) private. I also refactored InitAsBubble and changed all uses of it to
Initialize. I decided to overload Initialize to accommodate its use by
app_list_presenter_delegate_mus.cc and a few other files. I couldn't default the
const gfx::Rect& parameter, and I didn't want to create a fake value for
gfx::Rect&. I'm not sure my way is the best way to handle this.

+
+  // Initializes the widget with a frame or a frameless view depending on
+  // command line switches.
+  void Initialize(gfx::NativeView parent,
+                  int initial_apps_page,
+                  const gfx::Rect display_work_area_bounds);
+
+  // Initializes the widget as a bubble. Integrated into Initialize but
+  // kept around for its usage in app_list_presenter_delegate_mus.cc.
   void InitAsBubble(gfx::NativeView parent, int initial_apps_page);
 
   void SetBubbleArrow(views::BubbleBorder::Arrow arrow);
 
   void SetAnchorPoint(const gfx::Point& anchor_point);
 
   // If |drag_and_drop_host| is not NULL it will be called upon drag and drop
   // operations outside the application list. This has to be called after
   // InitAsBubble was called since the app list object needs to exist so that
   // it can set the host.
@@ skipping 10 matching lines @@
 
   // Enables/disables a semi-transparent overlay over the app list (good for
   // hiding the app list when a modal dialog is being shown).
   void SetAppListOverlayVisible(bool visible);
 
   views::Widget* search_box_widget() const { return search_box_widget_; }
 
   // Overridden from views::View:
   gfx::Size GetPreferredSize() const override;
   void OnPaint(gfx::Canvas* canvas) override;
+  const char* GetClassName() const override;
 
   // WidgetDelegate overrides:
   bool ShouldHandleSystemCommands() const override;
   bool ShouldDescendIntoChildForEventHandling(
       gfx::NativeView child,
       const gfx::Point& location) override;
 
   AppListMainView* app_list_main_view() { return app_list_main_view_; }
 
   // Gets the PaginationModel owned by this view's apps grid.
@@ skipping 28 matching lines @@
   // Overridden from SpeechUIModelObserver:
   void OnSpeechRecognitionStateChanged(
       SpeechRecognitionState new_state) override;
 
   AppListViewDelegate* delegate_;  // Weak. Owned by AppListService.
 
   AppListMainView* app_list_main_view_;
   SpeechView* speech_view_;
 
   views::View* search_box_focus_host_;  // Owned by the views hierarchy.
-  views::Widget* search_box_widget_;  // Owned by the app list's widget.
-  SearchBoxView* search_box_view_;    // Owned by |search_box_widget_|.
+  views::Widget* search_box_widget_;    // Owned by the app list's widget.
+  SearchBoxView* search_box_view_;      // Owned by |search_box_widget_|.
 
   // A semi-transparent white overlay that covers the app list while dialogs are
   // open.
   views::View* overlay_view_;
 
   std::unique_ptr<HideViewAnimationObserver> animation_observer_;
 
   // For UMA and testing. If non-null, triggered when the app list is painted.
   base::Closure next_paint_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(AppListView);
 };
 
 }  // namespace app_list
 
 #endif  // UI_APP_LIST_VIEWS_APP_LIST_VIEW_H_