Implementation of a full screen app list and re-alphabetized switches

ui/app_list/views/app_list_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_view.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/macros.h"
@@ skipping 66 matching lines @@
 };
 
 // The view for the App List overlay, which appears as a white rounded
 // rectangle with the given radius.
 class AppListOverlayView : public views::View {
  public:
   explicit AppListOverlayView(int corner_radius)
       : corner_radius_(corner_radius) {
     SetPaintToLayer();
     SetVisible(false);
-    layer()->SetOpacity(0.0f);

[sky, 2017/04/07 03:28:18]

Why are you removing this?

[newcomer, 2017/04/10 16:34:53]

That was a mistake! Fixed.

   }
 
   ~AppListOverlayView() override {}
 
   // Overridden from views::View:
   void OnPaint(gfx::Canvas* canvas) override {
     cc::PaintFlags flags;
     flags.setStyle(cc::PaintFlags::kFill_Style);
     flags.setColor(SK_ColorWHITE);
     canvas->DrawRoundRect(GetContentsBounds(), corner_radius_, flags);
@@ skipping 64 matching lines @@
 
   views::BubbleFrameView* frame_;
   views::View* target_;
 
   DISALLOW_COPY_AND_ASSIGN(HideViewAnimationObserver);
 };
 
 ////////////////////////////////////////////////////////////////////////////////
 // AppListView:
 
+const char* AppListView::GetClassName() const {
+  return "AppListView";
+}
+
 AppListView::AppListView(AppListViewDelegate* delegate)
     : delegate_(delegate),
       app_list_main_view_(nullptr),
       speech_view_(nullptr),
       search_box_focus_host_(nullptr),
       search_box_widget_(nullptr),
       search_box_view_(nullptr),
       overlay_view_(nullptr),
-      animation_observer_(new HideViewAnimationObserver()) {
+      animation_observer_(new HideViewAnimationObserver()),
+      blurred(false) {

[sky, 2017/04/07 03:28:19]

Does this compile?

[newcomer, 2017/04/10 16:34:53]

It didn't compile. I added that when doing research on the codebase and
accidentally put it in the CL.

   CHECK(delegate);
 
   delegate_->GetSpeechUI()->AddObserver(this);
 }
 
 AppListView::~AppListView() {
   delegate_->GetSpeechUI()->RemoveObserver(this);
   animation_observer_.reset();
   // Remove child views first to ensure no remaining dependencies on delegate_.
   RemoveAllChildViews(true);
 }
 
+void AppListView::InitAsFramelessWindow(gfx::NativeView parent,

[sky, 2017/04/07 03:28:18]

Please refactor this and InitAsBubble to share code. In particular I'm assuming
the accelerator, targeter and other functionality should be shared.

[newcomer, 2017/04/10 16:34:53]

I refactored it, then noticed there was a function calling InitAsBubble ( see
the most recent patch please for full explanation )

+                                        int initial_apps_page,
+                                        gfx::Rect bounds) {
+  set_color(kContentsBackgroundColor);
+  InitContents(parent, initial_apps_page);
+

[sky, 2017/04/07 03:28:18]

Only one newline is fine.

[newcomer, 2017/04/10 16:34:53]

Acknowledged.

+
+  views::Widget *widget = new views::Widget;
+  views::Widget::InitParams app_list_overlay_view_params(
+      views::Widget::InitParams::TYPE_WINDOW_FRAMELESS);
+  app_list_overlay_view_params.parent = parent;
+  app_list_overlay_view_params.delegate = this;
+
+  widget->Init(app_list_overlay_view_params);
+  widget->SetBounds(bounds);
+  widget->GetLayer()->SetFillsBoundsOpaquely(false);
+  widget->GetLayer()->SetBackgroundBlur(20);
+  InitChildWidgets();
+  overlay_view_ = new AppListOverlayView(0 /* no corners */);
+  AddChildView(overlay_view_);
+}
 void AppListView::InitAsBubble(gfx::NativeView parent, int initial_apps_page) {

[sky, 2017/04/07 03:28:18]

newline between 217/218.

   base::Time start_time = base::Time::Now();
 
   InitContents(parent, initial_apps_page);
 
   AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE));
   set_margins(gfx::Insets());
   set_parent_window(parent);
   set_close_on_deactivate(false);
   set_shadow(views::BubbleBorder::NO_ASSETS);
   set_color(kContentsBackgroundColor);
@@ skipping 132 matching lines @@
   // crbug.com/441028 are fixed.
   tracked_objects::ScopedTracker tracking_profile(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "440224, 441028 AppListView::InitContents"));
 
   app_list_main_view_ = new AppListMainView(delegate_);
   AddChildView(app_list_main_view_);
   app_list_main_view_->SetPaintToLayer();
   app_list_main_view_->layer()->SetFillsBoundsOpaquely(false);
   app_list_main_view_->layer()->SetMasksToBounds(true);
-
   // This will be added to the |search_box_widget_| after the app list widget is
   // initialized.
   search_box_view_ = new SearchBoxView(app_list_main_view_, delegate_);
   search_box_view_->SetPaintToLayer();
   search_box_view_->layer()->SetFillsBoundsOpaquely(false);
   search_box_view_->layer()->SetMasksToBounds(true);
 
   // TODO(vadimt): Remove ScopedTracker below once crbug.com/440224 and
   // crbug.com/441028 are fixed.
   tracked_objects::ScopedTracker tracking_profile1(
@@ skipping 210 matching lines @@
     app_list_main_view_->SetVisible(true);
     // Refocus the search box. However, if the app list widget does not have
     // focus, it means another window has already taken focus, and we *must not*
     // focus the search box (or we would steal focus back into the app list).
     if (GetWidget()->IsActive())
       search_box_view_->search_box()->RequestFocus();
   }
 }
 
 }  // namespace app_list