Implementation of a full screen app list and re-alphabetized switches

ash/app_list/app_list_presenter_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/app_list/app_list_presenter_delegate.h"
 
 #include "ash/common/ash_switches.h"
 #include "ash/common/shelf/app_list_button.h"
 #include "ash/common/shelf/shelf_layout_manager.h"
 #include "ash/common/shelf/shelf_widget.h"
@@ skipping 81 matching lines @@
   // UI layout when AppListView visibility changes.
   ash::Shell::GetPrimaryRootWindowController()
       ->GetShelfLayoutManager()
       ->UpdateAutoHideState();
   view_ = view;
   WmWindow* wm_root_window =
       WmShell::Get()->GetRootWindowForDisplayId(display_id);
   aura::Window* root_window = wm_root_window->aura_window();
   aura::Window* container = GetRootWindowController(root_window)
                                 ->GetContainer(kShellWindowId_AppListContainer);
-  view->InitAsBubble(container, current_apps_page);
-  // The app list is centered over the display.
-  view->SetAnchorPoint(GetCenterOfDisplayForWindow(
-      wm_root_window, GetMinimumBoundsHeightForAppList(view)));
+  // fullscreen
+  if (CheckFullscreenAppListEnabled()) {

[sky, 2017/04/07 03:28:18]

IsFullscreenAppListEnabled()? Or perhaps ShouldCreateFullScreenWindow().

[newcomer, 2017/04/10 16:34:53]

Done.

+    view->InitAsFramelessWindow(
+        container, current_apps_page,
+        ScreenUtil::GetDisplayWorkAreaBoundsInParent(container));
+  } else {
+    view->InitAsBubble(container, current_apps_page);
+    // The app list is centered over the display.
+    view->SetAnchorPoint(GetCenterOfDisplayForWindow(
+        wm_root_window, GetMinimumBoundsHeightForAppList(view)));
+  }
+
 
   keyboard::KeyboardController* keyboard_controller =
       keyboard::KeyboardController::GetInstance();
   if (keyboard_controller)
     keyboard_controller->AddObserver(this);
   Shell::GetInstance()->AddPreTargetHandler(this);
   WmShelf* shelf = WmShelf::ForWindow(wm_root_window);
   shelf->AddObserver(this);
 
   // By setting us as DnD recipient, the app list knows that we can
@@ skipping 54 matching lines @@
     case SHELF_ALIGNMENT_RIGHT:
       return gfx::Vector2d(kAnimationOffset, 0);
   }
   NOTREACHED();
   return gfx::Vector2d();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AppListPresenterDelegate, private:
 
+bool AppListPresenterDelegate::CheckFullscreenAppListEnabled() {
+    return base::CommandLine::ForCurrentProcess()->HasSwitch(

[sky, 2017/04/07 03:28:18]

This doesn't use any state from AppListPresenterDelegate. Prefer a standalone
non-member function in this case (in the anonymous namespace at the top of the
file).

[newcomer, 2017/04/10 16:34:53]

Done.

+                switches::kAshEnableFullscreenAppList);
+}
+
 void AppListPresenterDelegate::ProcessLocatedEvent(ui::LocatedEvent* event) {
   if (!view_ || !is_visible_)
     return;
 
   // If the event happened on a menu, then the event should not close the app
   // list.
   aura::Window* target = static_cast<aura::Window*>(event->target());
   if (target) {
     RootWindowController* root_controller =
         GetRootWindowController(target->GetRootWindow());
@@ skipping 48 matching lines @@
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AppListPresenterDelegate, WmShelfObserver implementation:
 
 void AppListPresenterDelegate::OnShelfIconPositionsChanged() {
   UpdateBounds();
 }
 
 }  // namespace ash