Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2802903002: Move PrintBrowser from SPV2 to SPV1 (Closed)
Patch Set: Clear the PrintContext when disposing of the FrameView Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/TextPainter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 HTMLFrameOwnerElement* owner_element = frame_->DeprecatedLocalOwner(); 377 HTMLFrameOwnerElement* owner_element = frame_->DeprecatedLocalOwner();
378 // TODO(dcheng): It seems buggy that we can have an owner element that points 378 // TODO(dcheng): It seems buggy that we can have an owner element that points
379 // to another FrameViewBase. This can happen when a plugin element loads a 379 // to another FrameViewBase. This can happen when a plugin element loads a
380 // frame (FrameViewBase A of type FrameView) and then loads a plugin 380 // frame (FrameViewBase A of type FrameView) and then loads a plugin
381 // (FrameViewBase B of type WebPluginContainerImpl). In this case, the frame's 381 // (FrameViewBase B of type WebPluginContainerImpl). In this case, the frame's
382 // view is A and the frame element's owned FrameViewBase is B. See 382 // view is A and the frame element's owned FrameViewBase is B. See
383 // https://crbug.com/673170 for an example. 383 // https://crbug.com/673170 for an example.
384 if (owner_element && owner_element->OwnedWidget() == this) 384 if (owner_element && owner_element->OwnedWidget() == this)
385 owner_element->SetWidget(nullptr); 385 owner_element->SetWidget(nullptr);
386 386
387 ClearPrintContext();
388
387 #if DCHECK_IS_ON() 389 #if DCHECK_IS_ON()
388 has_been_disposed_ = true; 390 has_been_disposed_ = true;
389 #endif 391 #endif
390 } 392 }
391 393
392 void FrameView::DetachScrollbars() { 394 void FrameView::DetachScrollbars() {
393 // Previously, we detached custom scrollbars as early as possible to prevent 395 // Previously, we detached custom scrollbars as early as possible to prevent
394 // Document::detachLayoutTree() from messing with the view such that its 396 // Document::detachLayoutTree() from messing with the view such that its
395 // scroll bars won't be torn down. However, scripting in 397 // scroll bars won't be torn down. However, scripting in
396 // Document::detachLayoutTree() is forbidden 398 // Document::detachLayoutTree() is forbidden
(...skipping 4937 matching lines...) Expand 10 before | Expand all | Expand 10 after
5334 void FrameView::SetAnimationHost( 5336 void FrameView::SetAnimationHost(
5335 std::unique_ptr<CompositorAnimationHost> host) { 5337 std::unique_ptr<CompositorAnimationHost> host) {
5336 animation_host_ = std::move(host); 5338 animation_host_ = std::move(host);
5337 } 5339 }
5338 5340
5339 LayoutUnit FrameView::CaretWidth() const { 5341 LayoutUnit FrameView::CaretWidth() const {
5340 return LayoutUnit(GetHostWindow()->WindowToViewportScalar(1)); 5342 return LayoutUnit(GetHostWindow()->WindowToViewportScalar(1));
5341 } 5343 }
5342 5344
5343 } // namespace blink 5345 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/TextPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698