Source/core/frame/LocalFrame.cpp - Issue 280283002: Stop firing orientationchange events at pages that are not visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 280283002: Stop firing orientationchange events at pages that are not visible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take feedback into consideration Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/LocalFrame.cpp

diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp

index e321c337713b91e0a6dec4724b374546a099a56d..1f83ef1573790435f7f86b5c2065822983d11949 100644

--- a/Source/core/frame/LocalFrame.cpp

+++ b/Source/core/frame/LocalFrame.cpp

@@ -166,6 +166,9 @@ void LocalFrame::sendOrientationChangeEvent()

if (!RuntimeEnabledFeatures::orientationEventEnabled() && !RuntimeEnabledFeatures::screenOrientationEnabled())

return;

+ if (page()->visibilityState() != PageVisibilityStateVisible)

+ return;

DOMWindow* window = domWindow();

if (!window)

return;