Stop firing orientationchange events at pages that are not visible

Source/modules/screen_orientation/ScreenOrientationController.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScreenOrientationController_h
 #define ScreenOrientationController_h
 
 #include "core/dom/DocumentSupplementable.h"
+#include "core/page/PageLifecycleObserver.h"
 #include "public/platform/WebScreenOrientationType.h"
 
 namespace WebCore {
 
 class FrameView;
 
-class ScreenOrientationController FINAL : public NoBaseWillBeGarbageCollected<ScreenOrientationController>, public DocumentSupplement {
+class ScreenOrientationController FINAL : public NoBaseWillBeGarbageCollected<ScreenOrientationController>, public DocumentSupplement, public PageLifecycleObserver {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ScreenOrientationController);
 public:
     virtual ~ScreenOrientationController();
 
     blink::WebScreenOrientationType orientation() const;
 
     // DocumentSupplement API.
     static ScreenOrientationController& from(Document&);
     static const char* supplementName();
 
 private:
     explicit ScreenOrientationController(Document&);
     static blink::WebScreenOrientationType computeOrientation(FrameView*);
 
+    // Inherited from PageLifecycleObserver.
+    virtual void pageVisibilityChanged() OVERRIDE;
+
     Document& m_document;
+    blink::WebScreenOrientationType m_lastVisibleOrientation;

[mlamouri (slow - plz ping), 2014/05/28 14:05:33]

Hmm, with your current implementation, this ought to be called
m_overrideOrientation given that you use that variable to also mark that the
current orientation should be ignored. More later.

[Inactive, 2014/05/28 15:27:28]

Done.

 };
 
 } // namespace WebCore
 
 #endif // ScreenOrientationController_h