Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: ios/chrome/browser/sessions/BUILD.gn

Issue 2802763002: [ios] Cleanup SessionServiceIOS implementation. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/sessions/BUILD.gn
diff --git a/ios/chrome/browser/sessions/BUILD.gn b/ios/chrome/browser/sessions/BUILD.gn
index 028a8b2c3c8de2830e5dbc6b120c809296ec9543..6111b6e3d362391f0edec9fe098c2517b24ba540 100644
--- a/ios/chrome/browser/sessions/BUILD.gn
+++ b/ios/chrome/browser/sessions/BUILD.gn
@@ -11,6 +11,8 @@ source_set("sessions") {
"ios_chrome_tab_restore_service_client.mm",
"ios_chrome_tab_restore_service_factory.cc",
"ios_chrome_tab_restore_service_factory.h",
+ "session_service_ios.h",
+ "session_service_ios.mm",
"session_window_ios.h",
"session_window_ios.mm",
]
@@ -36,8 +38,6 @@ source_set("sessions_non_arc") {
sources = [
"NSCoder+Compatibility.h",
"NSCoder+Compatibility.mm",
- "session_service.h",
- "session_service.mm",
"session_util.h",
"session_util.mm",
"tab_restore_service_delegate_impl_ios.h",
@@ -75,25 +75,10 @@ source_set("unit_tests") {
configs += [ "//build/config/compiler:enable_arc" ]
testonly = true
sources = [
+ "session_service_ios_unittest.mm",
"session_window_ios_unittest.mm",
]
deps = [
- ":sessions",
- ":unit_tests_non_arc",
- "//base",
- "//ios/web",
- "//testing/gtest",
- ]
- libs = [ "Foundation.framework" ]
-}
-
-source_set("unit_tests_non_arc") {
- configs += [ "//build/config/compiler:enable_arc" ]
- testonly = true
- sources = [
- "session_service_unittest.mm",
- ]
- deps = [
":resources_unit_tests",
":sessions",
"//base",
@@ -104,10 +89,11 @@ source_set("unit_tests_non_arc") {
"//testing/gtest",
"//third_party/ocmock",
]
+ libs = [ "Foundation.framework" ]
}
bundle_data("resources_unit_tests") {
- visibility = [ ":unit_tests_non_arc" ]
+ visibility = [ ":unit_tests" ]
testonly = true
sources = [
"//ios/chrome/test/data/sessions/corrupted.plist",
« no previous file with comments | « ios/chrome/browser/crash_report/crash_restore_helper_unittest.mm ('k') | ios/chrome/browser/sessions/session_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698