Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: ios/chrome/browser/test/perf_test_with_bvc_ios.mm

Issue 2802763002: [ios] Cleanup SessionServiceIOS implementation. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/test/perf_test_with_bvc_ios.h" 5 #include "ios/chrome/browser/test/perf_test_with_bvc_ios.h"
6 6
7 #import <UIKit/UIKit.h> 7 #import <UIKit/UIKit.h>
8 8
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/strings/sys_string_conversions.h" 11 #include "base/strings/sys_string_conversions.h"
12 #include "components/bookmarks/test/bookmark_test_helpers.h" 12 #include "components/bookmarks/test/bookmark_test_helpers.h"
13 #include "ios/chrome/browser/autocomplete/autocomplete_classifier_factory.h" 13 #include "ios/chrome/browser/autocomplete/autocomplete_classifier_factory.h"
14 #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h" 14 #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"
15 #include "ios/chrome/browser/browser_state/test_chrome_browser_state_manager.h" 15 #include "ios/chrome/browser/browser_state/test_chrome_browser_state_manager.h"
16 #include "ios/chrome/browser/search_engines/template_url_service_factory.h" 16 #include "ios/chrome/browser/search_engines/template_url_service_factory.h"
17 #import "ios/chrome/browser/sessions/session_service.h" 17 #import "ios/chrome/browser/sessions/session_service_ios.h"
18 #import "ios/chrome/browser/sessions/session_window_ios.h" 18 #import "ios/chrome/browser/sessions/session_window_ios.h"
19 #import "ios/chrome/browser/tabs/tab_model.h" 19 #import "ios/chrome/browser/tabs/tab_model.h"
20 #import "ios/chrome/browser/ui/browser_view_controller.h" 20 #import "ios/chrome/browser/ui/browser_view_controller.h"
21 #import "ios/chrome/browser/ui/browser_view_controller_dependency_factory.h" 21 #import "ios/chrome/browser/ui/browser_view_controller_dependency_factory.h"
22 #import "ios/chrome/browser/ui/preload_controller.h" 22 #import "ios/chrome/browser/ui/preload_controller.h"
23 #import "ios/chrome/browser/web/chrome_web_client.h" 23 #import "ios/chrome/browser/web/chrome_web_client.h"
24 #include "ios/public/provider/chrome/browser/chrome_browser_provider.h" 24 #include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
25 25
26 // Subclass of PrerenderController so it isn't actually used. Using a mock for 26 // Subclass of PrerenderController so it isn't actually used. Using a mock for
27 // this makes cleanup on shutdown simpler, by minimizing the number of profile 27 // this makes cleanup on shutdown simpler, by minimizing the number of profile
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 // NSAutoreleasePool can drain. This needs to be done before 166 // NSAutoreleasePool can drain. This needs to be done before
167 // |chrome_browser_state_| can be cleared. For tests that allocate more 167 // |chrome_browser_state_| can be cleared. For tests that allocate more
168 // objects, more runloop time may be required. 168 // objects, more runloop time may be required.
169 if (slow_teardown_) 169 if (slow_teardown_)
170 SpinRunLoop(.5); 170 SpinRunLoop(.5);
171 PerfTest::TearDown(); 171 PerfTest::TearDown();
172 172
173 // The profiles can be deallocated only after the BVC has been deallocated. 173 // The profiles can be deallocated only after the BVC has been deallocated.
174 chrome_browser_state_.reset(); 174 chrome_browser_state_.reset();
175 } 175 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/chrome/browser/ui/main/browser_view_wrangler.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698