Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: chrome/browser/ui/browser_dialogs.h

Issue 2802703004: Log creation for many dialog box types. (Closed)
Patch Set: qualify RecordDialogCreation with chrome:: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_dialogs.h
diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h
index a4a4dc8cc16d2db621f0b71279207cf489dafe4e..e9ded031eb2732473dedc60d87c97c0d363625c3 100644
--- a/chrome/browser/ui/browser_dialogs.h
+++ b/chrome/browser/ui/browser_dialogs.h
@@ -190,7 +190,28 @@ class ContentSettingBubbleViewsBridge {
// different type of dialog box.
// These values are written to logs. New enum values can be added, but existing
// enums must never be renumbered or deleted and reused.
-enum class DialogIdentifier { UNKNOWN = 0, TRANSLATE = 1, MAX_VALUE };
+enum class DialogIdentifier {
+ UNKNOWN = 0,
+ TRANSLATE = 1,
+ BOOKMARK = 2,
+ BOOKMARK_EDITOR = 3,
+ SCREENSHARE = 4,
+ OUTDATED_UPGRADE = 5,
+ ONE_CLICK_SIGNIN = 6,
+ LINK_CHROME_DATA = 7,
+ HUNG_RENDERER = 8,
+ SESSION_CRASHED = 9,
+ ASK_GOOGLE_FOR_SUGGESTIONS = 10,
+ UPDATE_RECOMMENDED = 11,
+ CRYPTO_PASSWORD = 12,
+ SAFE_BROWSING_DOWNLOAD_FEEDBACK = 13,
+ FIRST_RUN = 14,
+ NETWORK_SHARE_PROFILE_WARNING = 15,
+ CONFLICTING_MODULE = 16,
+ CRITICAL_UPGRADE_INSTALLED = 17,
+ IME_ACTIVATION = 18,
+ MAX_VALUE
+};
// Record an UMA metric counting the creation of a dialog box of this type.
void RecordDialogCreation(DialogIdentifier identifier);

Powered by Google App Engine
This is Rietveld 408576698