Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/ui/browser_dialogs.h

Issue 2802703004: Log creation for many dialog box types. (Closed)
Patch Set: Enums better match class names. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_DIALOGS_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
6 #define CHROME_BROWSER_UI_BROWSER_DIALOGS_H_ 6 #define CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 }; 181 };
182 182
183 #endif // OS_MACOSX 183 #endif // OS_MACOSX
184 184
185 #endif // TOOLKIT_VIEWS 185 #endif // TOOLKIT_VIEWS
186 186
187 // Values used in the Dialog.Creation UMA metric. Each value represents a 187 // Values used in the Dialog.Creation UMA metric. Each value represents a
188 // different type of dialog box. 188 // different type of dialog box.
189 // These values are written to logs. New enum values can be added, but existing 189 // These values are written to logs. New enum values can be added, but existing
190 // enums must never be renumbered or deleted and reused. 190 // enums must never be renumbered or deleted and reused.
191 enum class DialogIdentifier { UNKNOWN = 0, TRANSLATE = 1, MAX_VALUE }; 191 enum class DialogIdentifier {
192 UNKNOWN = 0,
193 TRANSLATE = 1,
194 BOOKMARK = 2,
195 BOOKMARK_EDITOR = 3,
196 DESKTOP_MEDIA_PICKER = 4,
197 OUTDATED_UPGRADE = 5,
198 ONE_CLICK_SIGNIN = 6,
199 PROFILE_SIGNIN_CONFIRMATION = 7,
200 HUNG_RENDERER = 8,
201 SESSION_CRASHED = 9,
202 CONFIRM_BUBBLE = 10,
203 UPDATE_RECOMMENDED = 11,
204 CRYPTO_PASSWORD = 12,
205 SAFE_BROWSING_DOWNLOAD_FEEDBACK = 13,
206 FIRST_RUN = 14,
207 NETWORK_SHARE_PROFILE_WARNING = 15,
208 CONFLICTING_MODULE = 16,
209 CRITICAL_NOTIFICATION = 17,
210 IME_WARNING = 18,
211 MAX_VALUE
212 };
192 213
193 // Record an UMA metric counting the creation of a dialog box of this type. 214 // Record an UMA metric counting the creation of a dialog box of this type.
194 void RecordDialogCreation(DialogIdentifier identifier); 215 void RecordDialogCreation(DialogIdentifier identifier);
195 216
196 #if defined(OS_WIN) 217 #if defined(OS_WIN)
197 218
198 // Shows the Chrome Cleanup dialog asking the user if they want to clean their 219 // Shows the Chrome Cleanup dialog asking the user if they want to clean their
199 // system from unwanted software. This is called when unwanted software has been 220 // system from unwanted software. This is called when unwanted software has been
200 // detected on the system. 221 // detected on the system.
201 void ShowSRTPrompt(Browser* browser, 222 void ShowSRTPrompt(Browser* browser,
(...skipping 18 matching lines...) Expand all
220 using BubbleShowPtr = 241 using BubbleShowPtr =
221 void (*)(content::WebContents*, 242 void (*)(content::WebContents*,
222 const std::vector<arc::ArcNavigationThrottle::AppInfo>&, 243 const std::vector<arc::ArcNavigationThrottle::AppInfo>&,
223 const IntentPickerResponse&); 244 const IntentPickerResponse&);
224 245
225 BubbleShowPtr ShowIntentPickerBubble(); 246 BubbleShowPtr ShowIntentPickerBubble();
226 247
227 #endif // OS_CHROMEOS 248 #endif // OS_CHROMEOS
228 249
229 #endif // CHROME_BROWSER_UI_BROWSER_DIALOGS_H_ 250 #endif // CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698