Handle const list and map literals.

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.body_builder;
 
 import '../fasta_codes.dart'
     show FastaMessage, codeExpectedButGot, codeExpectedFunctionBody;
 
 import '../parser/parser.dart' show FormalParameterType, optional;
@@ skipping 729 matching lines @@
   /// if the name doesn't resolve in the scope).
   @override
   scopeLookup(Scope scope, String name, int charOffset,
       {bool isQualified: false}) {
     Builder builder = scope.lookup(name, charOffset, uri);
     if (builder == null || (!isInstanceContext && builder.isInstanceMember)) {
       Name n = new Name(name, library.library);
       if (!isQualified && isInstanceContext) {
         assert(builder == null);
         if (constantExpressionRequired) {
-          addCompileTimeError(charOffset, "Not a constant expression.");
+          return new UnresolvedAccessor(this, n, charOffset);
         }
         return new ThisPropertyAccessor(this, charOffset, n, null, null);
       } else if (isDartLibrary &&
           name == "main" &&
           library.uri.path == "_builtin" &&
           member?.name == "_getMainClosure") {
         // TODO(ahe): https://github.com/dart-lang/sdk/issues/28989
         return new NullLiteral()..fileOffset = charOffset;
       } else {
         return new UnresolvedAccessor(this, n, charOffset);
@@ skipping 368 matching lines @@
   void handleLiteralList(
       int count, Token beginToken, Token constKeyword, Token endToken) {
     debugEvent("LiteralList");
     List<Expression> expressions = popListForValue(count);
     List<DartType> typeArguments = pop();
     DartType typeArgument = const DynamicType();
     if (typeArguments != null) {
       typeArgument = typeArguments.first;
       if (typeArguments.length > 1) {
         typeArgument = const DynamicType();
-        warning(
+        warningNotError(
             "Too many type arguments on List literal.", beginToken.charOffset);
       }
     }
     push(new ListLiteral(expressions,
         typeArgument: typeArgument, isConst: constKeyword != null)
       ..fileOffset = constKeyword?.charOffset ?? beginToken.charOffset);
   }
 
   @override
   void handleLiteralBool(Token token) {
@@ skipping 21 matching lines @@
       int count, Token beginToken, Token constKeyword, Token endToken) {
     debugEvent("LiteralMap");
     List<MapEntry> entries = popList(count) ?? <MapEntry>[];
     List<DartType> typeArguments = pop();
     DartType keyType = const DynamicType();
     DartType valueType = const DynamicType();
     if (typeArguments != null) {
       if (typeArguments.length != 2) {
         keyType = const DynamicType();
         valueType = const DynamicType();
-        warning(
+        warningNotError(
             "Map literal requires two type arguments.", beginToken.charOffset);
       } else {
         keyType = typeArguments[0];
         valueType = typeArguments[1];
       }
     }
     push(new MapLiteral(entries,
         keyType: keyType, valueType: valueType, isConst: constKeyword != null)
       ..fileOffset = constKeyword?.charOffset ?? beginToken.charOffset);
   }
@@ skipping 47 matching lines @@
       Builder builder, List<DartType> arguments, int charOffset) {
     if (constantExpressionRequired && builder is TypeVariableBuilder) {
       addCompileTimeError(charOffset, "Not a constant expression.");
     }
     if (builder is TypeDeclarationBuilder) {
       return builder.buildTypesWithBuiltArguments(library, arguments);
     } else if (builder.hasProblem) {
       ProblemBuilder problem = builder;
       addCompileTimeError(charOffset, problem.message);
     } else {
-      warning("Not a type: '${builder.fullNameForErrors}'.", charOffset);
+      warningNotError(
+          "Not a type: '${builder.fullNameForErrors}'.", charOffset);
     }
     // TODO(ahe): Create an error somehow.
     return const DynamicType();
   }
 
   @override
   void handleType(Token beginToken, Token endToken) {
     // TODO(ahe): The scope is wrong for return types of generic functions.
     debugEvent("Type");
     List<DartType> arguments = pop();
@@ skipping 23 matching lines @@
         push(const DynamicType());
         addCompileTimeError(beginToken.charOffset,
             "Can't be used as a type: '${debugName(prefix, suffix)}'.");
         return;
       }
     }
     if (name is Identifier) {
       name = name.name;
     }
     if (name is FastaAccessor) {
-      warning("'${beginToken.lexeme}' isn't a type.", beginToken.charOffset);
+      warningNotError(
+          "'${beginToken.lexeme}' isn't a type.", beginToken.charOffset);
       push(const DynamicType());
     } else if (name is TypeVariableBuilder) {
       if (constantExpressionRequired) {
         addCompileTimeError(
             beginToken.charOffset, "Not a constant expression.");
       }
       push(name.buildTypesWithBuiltArguments(library, arguments));
     } else if (name is TypeDeclarationBuilder) {
       push(name.buildTypesWithBuiltArguments(library, arguments));
     } else if (name is TypeBuilder) {
@@ skipping 441 matching lines @@
   }
 
   @override
   void beginConstExpression(Token token) {
     debugEvent("beginConstExpression");
     super.push(constantExpressionRequired);
     constantExpressionRequired = true;
   }
 
   @override
+  void beginConstLiteral(Token token) {
+    debugEvent("beginConstLiteral");
+    super.push(constantExpressionRequired);
+    constantExpressionRequired = true;
+  }
+
+  @override
+  void endConstLiteral(Token token) {
+    debugEvent("endConstLiteral");
+    var literal = pop();
+    constantExpressionRequired = pop();
+    push(literal);
+  }
+
+  @override
   void endNewExpression(Token token) {
     debugEvent("NewExpression");
     Token nameToken = token.next;
     Arguments arguments = pop();
     String name = pop();
     List<DartType> typeArguments = pop();
     var type = pop();
     bool savedConstantExpressionRequired = pop();
     () {
       if (arguments == null) {
@@ skipping 651 matching lines @@
 
   @override
   void warning(String message, [int charOffset = -1]) {
     if (constantExpressionRequired) {
       addCompileTimeError(charOffset, message);
     } else {
       super.warning(message, charOffset);
     }
   }
 
+  void warningNotError(String message, [int charOffset = -1]) {
+    super.warning(message, charOffset);
+  }
+
   Expression evaluateArgumentsBefore(
       Arguments arguments, Expression expression) {
     if (arguments == null) return expression;
     List<Expression> expressions =
         new List<Expression>.from(arguments.positional);
     for (NamedExpression named in arguments.named) {
       expressions.add(named.value);
     }
     for (Expression argument in expressions.reversed) {
       expression = new Let(
@@ skipping 468 matching lines @@
   } else if (node is PrefixBuilder) {
     return node.name;
   } else if (node is ThisAccessor) {
     return node.isSuper ? "super" : "this";
   } else if (node is FastaAccessor) {
     return node.plainNameForRead;
   } else {
     return internalError("Unhandled: ${node.runtimeType}");
   }
 }