Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: components/translate/core/browser/translate_manager_unittest.cc

Issue 2802613004: fix target language issue under three locales (Hebrew[iw->he], Fillipion[tl->fil], and Nowreign[no-… (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_manager_unittest.cc
diff --git a/components/translate/core/browser/translate_manager_unittest.cc b/components/translate/core/browser/translate_manager_unittest.cc
index cf2898738d75bdcc4f5603c6daf72b13d0c419ad..3efddafc38fee98edf1c9f76bba479cba9069d1b 100644
--- a/components/translate/core/browser/translate_manager_unittest.cc
+++ b/components/translate/core/browser/translate_manager_unittest.cc
@@ -254,6 +254,23 @@ TEST_F(TranslateManagerTest, GetTargetLanguageDefaultsToAppLocale) {
ASSERT_TRUE(TranslateDownloadManager::IsSupportedLanguage("de"));
manager_->set_application_locale("de");
EXPECT_EQ("de", TranslateManager::GetTargetLanguage(&translate_prefs_));
+
+ // Try a those case of non standard code.
+ // 'he', 'fil', 'nb' => 'iw', 'tl', 'no'
+ ASSERT_TRUE(TranslateDownloadManager::IsSupportedLanguage("iw"));
+ ASSERT_FALSE(TranslateDownloadManager::IsSupportedLanguage("he"));
+ manager_->set_application_locale("he");
+ EXPECT_EQ("iw", TranslateManager::GetTargetLanguage(&translate_prefs_));
+
+ ASSERT_TRUE(TranslateDownloadManager::IsSupportedLanguage("tl"));
+ ASSERT_FALSE(TranslateDownloadManager::IsSupportedLanguage("fil"));
+ manager_->set_application_locale("fil");
+ EXPECT_EQ("tl", TranslateManager::GetTargetLanguage(&translate_prefs_));
+
+ ASSERT_TRUE(TranslateDownloadManager::IsSupportedLanguage("no"));
+ ASSERT_FALSE(TranslateDownloadManager::IsSupportedLanguage("nb"));
+ manager_->set_application_locale("nb");
+ EXPECT_EQ("no", TranslateManager::GetTargetLanguage(&translate_prefs_));
}
// If the application locale's language is not supported, the target language

Powered by Google App Engine
This is Rietveld 408576698