fix target language issue under three locales (Hebrew[iw->he], Fillipion[tl->fil], and Nowreign[no-…

components/translate/core/browser/translate_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_manager.h"
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 496 matching lines @@
   // If there are no override.
   if (language.empty()) {
     // Get the language from ULP.
     language = TranslateManager::GetTargetLanguageFromULP(prefs);
     if (!language.empty())
       return language;
 
     // Get the browser's user interface language.
     language = TranslateDownloadManager::GetLanguageCode(
         TranslateDownloadManager::GetInstance()->application_locale());
+    // Map 'he', 'nb', 'fil' back to 'iw', 'no', 'tl'
+    translate::ToTranslateLanguageSynonym(&language);

[jungshik at Google, 2017/04/11 18:45:32]

Shouldn't Google Translate API take care of this instead of clients like Chrome
doing this on their end?  

That is, Google Translate API should accept both {he,iw}, {tl, fil}, {nb, no}
and treat them as synonyms? 

   }
   if (TranslateDownloadManager::IsSupportedLanguage(language))
     return language;
 
   // Will translate to the first supported language on the Accepted Language
   // list or not at all if no such candidate exists.
   std::vector<std::string> accept_languages_list;
   prefs->GetLanguageList(&accept_languages_list);
   for (const auto& lang : accept_languages_list) {
     std::string lang_code = TranslateDownloadManager::GetLanguageCode(lang);
@@ skipping 76 matching lines @@
 void TranslateManager::RecordTranslateEvent(int event_type) {
   DCHECK(metrics::TranslateEventProto::EventType_IsValid(event_type));
   translate_event_->set_event_type(
       static_cast<metrics::TranslateEventProto::EventType>(event_type));
   translate_event_->set_event_timestamp_sec(
       (base::TimeTicks::Now() - base::TimeTicks()).InSeconds());
   translate_ranker_->AddTranslateEvent(*translate_event_);
 }
 
 }  // namespace translate