Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h

Issue 2802593002: Allow null other.m_parent in TraceWrapperMember::operator= if other is nullptr. (Closed)
Patch Set: m_parent swap test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
index 17a499dd2be9c87f9dd47f779add5cadd5d73511..0a55521bc80257b7574e3f4ea1bace04f824c09c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
+++ b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
@@ -50,7 +50,7 @@ class TraceWrapperMember : public Member<T> {
TraceWrapperMember(const TraceWrapperMember& other) { *this = other; }
TraceWrapperMember& operator=(const TraceWrapperMember& other) {
- DCHECK(other.m_parent);
+ DCHECK(!other.m_raw || other.m_parent);
m_parent = other.m_parent;
Member<T>::operator=(other);
ScriptWrappableVisitor::writeBarrier(m_parent, other);
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698