Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp

Issue 2802593002: Allow null other.m_parent in TraceWrapperMember::operator= if other is nullptr. (Closed)
Patch Set: m_parent swap test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/TraceWrapperMember.h" 5 #include "bindings/core/v8/TraceWrapperMember.h"
6 6
7 #include "core/testing/DeathAwareScriptWrappable.h" 7 #include "core/testing/DeathAwareScriptWrappable.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 namespace {
13
14 using Wrapper = TraceWrapperMember<DeathAwareScriptWrappable>;
15
16 } // namespace
17
12 TEST(TraceWrapperMemberTest, HeapVectorSwap) { 18 TEST(TraceWrapperMemberTest, HeapVectorSwap) {
13 typedef TraceWrapperMember<DeathAwareScriptWrappable> Wrapper;
14
15 HeapVector<Wrapper> vector1; 19 HeapVector<Wrapper> vector1;
16 DeathAwareScriptWrappable* parent1 = DeathAwareScriptWrappable::create(); 20 DeathAwareScriptWrappable* parent1 = DeathAwareScriptWrappable::create();
17 DeathAwareScriptWrappable* child1 = DeathAwareScriptWrappable::create(); 21 DeathAwareScriptWrappable* child1 = DeathAwareScriptWrappable::create();
18 vector1.push_back(Wrapper(parent1, child1)); 22 vector1.push_back(Wrapper(parent1, child1));
19 23
20 HeapVector<Wrapper> vector2; 24 HeapVector<Wrapper> vector2;
21 DeathAwareScriptWrappable* parent2 = DeathAwareScriptWrappable::create(); 25 DeathAwareScriptWrappable* parent2 = DeathAwareScriptWrappable::create();
22 DeathAwareScriptWrappable* child2 = DeathAwareScriptWrappable::create(); 26 DeathAwareScriptWrappable* child2 = DeathAwareScriptWrappable::create();
23 vector2.push_back(Wrapper(parent2, child2)); 27 vector2.push_back(Wrapper(parent2, child2));
24 28
25 swap(vector1, vector2, parent1, parent2); 29 swap(vector1, vector2, parent1, parent2);
26 EXPECT_EQ(parent1, vector1.front().parent()); 30 EXPECT_EQ(parent1, vector1.front().parent());
27 EXPECT_EQ(parent2, vector2.front().parent()); 31 EXPECT_EQ(parent2, vector2.front().parent());
28 } 32 }
29 33
30 TEST(TraceWrapperMemberTest, HeapVectorSwap2) { 34 TEST(TraceWrapperMemberTest, HeapVectorSwap2) {
31 typedef TraceWrapperMember<DeathAwareScriptWrappable> Wrapper;
32
33 HeapVector<Wrapper> vector1; 35 HeapVector<Wrapper> vector1;
34 DeathAwareScriptWrappable* parent1 = DeathAwareScriptWrappable::create(); 36 DeathAwareScriptWrappable* parent1 = DeathAwareScriptWrappable::create();
35 DeathAwareScriptWrappable* child1 = DeathAwareScriptWrappable::create(); 37 DeathAwareScriptWrappable* child1 = DeathAwareScriptWrappable::create();
36 vector1.push_back(Wrapper(parent1, child1)); 38 vector1.push_back(Wrapper(parent1, child1));
37 39
38 HeapVector<Member<DeathAwareScriptWrappable>> vector2; 40 HeapVector<Member<DeathAwareScriptWrappable>> vector2;
39 DeathAwareScriptWrappable* child2 = DeathAwareScriptWrappable::create(); 41 DeathAwareScriptWrappable* child2 = DeathAwareScriptWrappable::create();
40 vector2.push_back(child2); 42 vector2.push_back(child2);
41 43
42 swap(vector1, vector2, parent1); 44 swap(vector1, vector2, parent1);
43 EXPECT_EQ(1u, vector1.size()); 45 EXPECT_EQ(1u, vector1.size());
44 EXPECT_EQ(child2, vector1.front().get()); 46 EXPECT_EQ(child2, vector1.front().get());
45 EXPECT_EQ(parent1, vector1.front().parent()); 47 EXPECT_EQ(parent1, vector1.front().parent());
46 EXPECT_EQ(1u, vector2.size()); 48 EXPECT_EQ(1u, vector2.size());
47 EXPECT_EQ(child1, vector2.front().get()); 49 EXPECT_EQ(child1, vector2.front().get());
48 } 50 }
49 51
52 TEST(TraceWrapperMemberTest, HeapHashSet) {
53 HeapHashSet<Wrapper> set;
54 DeathAwareScriptWrappable* parent = DeathAwareScriptWrappable::create();
55
56 // Loop enough so that underlying HashTable will rehash several times.
57 for (int i = 1; i < 10000; ++i) {
58 DeathAwareScriptWrappable* child = DeathAwareScriptWrappable::create();
59 set.insert(Wrapper(parent, child));
60 }
61 EXPECT_EQ(9999u, set.size());
62
63 HeapHashSet<Wrapper> set2;
64 swap(set, set2);
65 EXPECT_EQ(0u, set.size());
66 EXPECT_EQ(9999u, set2.size());
67
68 for (int i = 1; i < 10000; ++i) {
69 auto wrapper = set2.takeAny();
70 EXPECT_EQ(wrapper.parent(), parent);
71 }
72
73 EXPECT_EQ(0u, set2.size());
74 }
75
76 TEST(TraceWrapperMemberTest, HeapHashMapValue) {
77 HeapHashMap<int, Wrapper> map;
78 DeathAwareScriptWrappable* parent = DeathAwareScriptWrappable::create();
79
80 // Loop enough so that underlying HashTable will rehash several times.
81 for (int i = 1; i < 10000; ++i) {
82 DeathAwareScriptWrappable* child = DeathAwareScriptWrappable::create();
83 map.insert(i, Wrapper(parent, child));
84 }
85 EXPECT_EQ(9999u, map.size());
86
87 for (int i = 1; i < 10000; ++i) {
88 auto wrapper = map.take(i);
89 EXPECT_EQ(wrapper.parent(), parent);
90 }
91
92 EXPECT_EQ(0u, map.size());
93 }
94
50 } // namespace blink 95 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698