gae cloud: Use with Datastore

impl/cloud/context.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package cloud
 
 import (
         "github.com/luci/gae/impl/dummy"
         ds "github.com/luci/gae/service/datastore"
         "github.com/luci/gae/service/mail"
@@ skipping 33 matching lines @@
         // Dummy services that we don't support.
         c = mail.Set(c, dummy.Mail())
         c = module.Set(c, dummy.Module())
         c = taskqueue.SetRaw(c, dummy.TaskQueue())
         c = user.Set(c, dummy.User())
 
         c = useInfo(c)
 
         // datastore service
         if cfg.DS != nil {
                 cds := cloudDatastore{

[nodir, 2017/04/05 22:10:51]

use UseWithDatastore here

[hinoka, 2017/04/06 17:46:03]

Done.

                         client: cfg.DS,
                 }
                 c = cds.use(c)
         } else {
                 c = ds.SetRaw(c, dummy.Datastore())
         }
 
         // memcache service
         if cfg.MC != nil {
                 mc := memcacheClient{
                         client: cfg.MC,
                 }
                 c = mc.use(c)
         } else {
                 c = mc.SetRaw(c, dummy.Memcache())
         }
 
         return c
 }
+
+// UseWithDatastore just install a datastore implementation into the context.

[nodir, 2017/04/05 22:10:51]

UseDatastore installs a cloud datastore implementation into the context

[hinoka, 2017/04/06 17:46:03]

Done.

+func UseWithDatastore(c context.Context, client *datastore.Client) context.Context {

[nodir, 2017/04/05 22:10:51]

two verbs? I think it should be either UseDatastore or WithDatastore. Other
functions in this code use Use, so maybe UseDatastore

[hinoka, 2017/04/06 17:46:03]

Done.

+        cds := cloudDatastore{
+                client: client,
+        }
+        return cds.use(c)
+}