ExtensionsTest: Move initialization to SetUp and avoid potential UAF.

extensions/browser/process_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/process_manager.h"
 
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/common/content_client.h"
 #include "content/public/test/test_browser_context.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extensions_test.h"
 #include "extensions/browser/notification_types.h"
 #include "extensions/browser/process_manager_delegate.h"
 #include "extensions/browser/test_extensions_browser_client.h"
@@ skipping 30 matching lines @@
   }
 
   bool is_background_page_allowed_;
   bool defer_creating_startup_background_hosts_;
 };
 
 }  // namespace
 
 class ProcessManagerTest : public ExtensionsTest {
  public:
-  ProcessManagerTest() : extension_registry_(browser_context()) {
+  ProcessManagerTest() {}
+
+  ~ProcessManagerTest() override {}
+
+  void SetUp() override {
+    ExtensionsTest::SetUp();
+    extension_registry_ =
+        base::MakeUnique<ExtensionRegistry>(browser_context());
     extensions_browser_client()->set_process_manager_delegate(
         &process_manager_delegate_);
   }
 
-  ~ProcessManagerTest() override {}
-
   // Use original_context() to make it clear it is a non-incognito context.
   BrowserContext* original_context() { return browser_context(); }
-  ExtensionRegistry* extension_registry() { return &extension_registry_; }
+  ExtensionRegistry* extension_registry() { return extension_registry_.get(); }
   TestProcessManagerDelegate* process_manager_delegate() {
     return &process_manager_delegate_;
   }
 
   // Returns true if the notification |type| is registered for |manager| with
   // source |context|. Pass NULL for |context| for all sources.
   static bool IsRegistered(ProcessManager* manager,
                            int type,
                            BrowserContext* context) {
     return manager->registrar_.IsRegistered(
         manager, type, content::Source<BrowserContext>(context));
   }
 
  private:
-  ExtensionRegistry extension_registry_;  // Shared between BrowserContexts.
+  std::unique_ptr<ExtensionRegistry>
+      extension_registry_;  // Shared between BrowserContexts.
   TestProcessManagerDelegate process_manager_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(ProcessManagerTest);
 };
 
 // Test that notification registration works properly.
 TEST_F(ProcessManagerTest, ExtensionNotificationRegistration) {
   // Test for a normal context ProcessManager.
   std::unique_ptr<ProcessManager> manager1(ProcessManager::CreateForTesting(
       original_context(), extension_registry()));
@@ skipping 135 matching lines @@
   scoped_refptr<SiteInstance> site21 =
       manager1->GetSiteInstanceForURL(ext2_url1);
   EXPECT_NE(site11, site21);
 
   scoped_refptr<SiteInstance> other_profile_site =
       manager2->GetSiteInstanceForURL(ext1_url1);
   EXPECT_NE(site11, other_profile_site);
 }
 
 }  // namespace extensions