Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 280243002: Avoid name clashes of builtins and runtime functions. (Closed)

Created:
6 years, 7 months ago by Jakob Kummerow
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Avoid name clashes of builtins and runtime functions. This makes it possible to use %Percent() notation to call any given builtin or runtime function in tests. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -122 lines) Patch
M src/array.js View 5 chunks +5 lines, -5 lines 0 comments Download
M src/arraybuffer.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/collection.js View 13 chunks +22 lines, -22 lines 0 comments Download
M src/harmony-math.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 5 chunks +5 lines, -5 lines 0 comments Download
M src/messages.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/object-observe.js View 6 chunks +9 lines, -9 lines 0 comments Download
M src/regexp.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/string.js View 10 chunks +18 lines, -18 lines 0 comments Download
M src/uri.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/v8natives.js View 20 chunks +22 lines, -22 lines 0 comments Download
D test/mjsunit/runtime-gen/mathexp.js View 1 chunk +0 lines, -5 lines 0 comments Download
A + test/mjsunit/runtime-gen/mathexprt.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/runtime-gen/mathfloor.js View 1 chunk +0 lines, -5 lines 0 comments Download
A + test/mjsunit/runtime-gen/mathfloorrt.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/runtime-gen/mathsqrt.js View 1 chunk +0 lines, -5 lines 0 comments Download
A + test/mjsunit/runtime-gen/mathsqrtrt.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
As discussed, I mostly resolved clashes by appending "JS" to the JavaScript names involved in ...
6 years, 7 months ago (2014-05-12 13:32:33 UTC) #1
Dmitry Lomov (no reviews)
lgtm
6 years, 7 months ago (2014-05-14 08:27:31 UTC) #2
Jakob Kummerow
6 years, 7 months ago (2014-05-14 08:51:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21298 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698