Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webkit/port/bindings/v8/v8_proxy.cpp

Issue 28024: Add a check for empty handle in V8Proxy::GetSourceLineNumber()... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/port/bindings/v8/v8_proxy.cpp
===================================================================
--- webkit/port/bindings/v8/v8_proxy.cpp (revision 10179)
+++ webkit/port/bindings/v8/v8_proxy.cpp (working copy)
@@ -3474,7 +3474,11 @@
if (frame_source_line.IsEmpty()) {
return 0;
}
- return v8::Debug::Call(frame_source_line)->Int32Value();
+ v8::Handle<v8::Value> result = v8::Debug::Call(frame_source_line);
+ if (result.IsEmpty()) {
+ return 0;
+ }
+ return result->Int32Value();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698