Issue 280223002: Fix windows x64 build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 280223002: Fix windows x64 build. (Closed)

Created:
6 years, 7 months ago by Yang

Modified:
6 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix windows x64 build. TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21263

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/d8.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 7 months ago (2014-05-12 11:49:35 UTC) #3

Message was sent while issue was closed.

Hmmm, this works, but actually I think that the bug is in the signature of
v8::V8::SetFlagsFromString: It should take a size_t, not an int. Almost all call
sites fight with that signature bug via ugly unsafe casting...

Expand Messages | Collapse Messages