third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp - Issue 2802223002: bindings: Throw a type error if converting an interface or callback function fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp

Issue 2802223002: bindings: Throw a type error if converting an interface or callback function fails. (Closed)

Patch Set: Add |callback_function_name| to the callback function template Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp

index ab58b8783940b5530c79aadd6fd982ad1b8a95d5..c577056afc993331f93de6a47f0b03750d8df5a3 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp

@@ -79,7 +79,10 @@ bool VoidCallbackFunction::call(ScriptWrappable* scriptWrappable) {

}

VoidCallbackFunction* NativeValueTraits<VoidCallbackFunction>::nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) {

- return VoidCallbackFunction::create(ScriptState::current(isolate), value);

+ VoidCallbackFunction* nativeValue = VoidCallbackFunction::create(ScriptState::current(isolate), value);

+ if (!nativeValue)

+ exceptionState.throwTypeError("Unable to convert value to VoidCallbackFunction.");

+ return nativeValue;

}

} // namespace blink