Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 2802213002: Simplify WebContentsState::GetContentsStateAsByteBuffer (Closed)
Patch Set: Addressed comments (@eugenebut) Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 BrowserContext* browser_context_; 356 BrowserContext* browser_context_;
357 357
358 // List of |NavigationEntry|s for this controller. 358 // List of |NavigationEntry|s for this controller.
359 std::vector<std::unique_ptr<NavigationEntryImpl>> entries_; 359 std::vector<std::unique_ptr<NavigationEntryImpl>> entries_;
360 360
361 // An entry we haven't gotten a response for yet. This will be discarded 361 // An entry we haven't gotten a response for yet. This will be discarded
362 // when we navigate again. It's used only so we know what the currently 362 // when we navigate again. It's used only so we know what the currently
363 // displayed tab is. 363 // displayed tab is.
364 // 364 //
365 // This may refer to an item in the entries_ list if the pending_entry_index_ 365 // This may refer to an item in the entries_ list if the pending_entry_index_
366 // == -1, or it may be its own entry that should be deleted. Be careful with 366 // != -1, or it may be its own entry that should be deleted. Be careful with
367 // the memory management. 367 // the memory management.
368 NavigationEntryImpl* pending_entry_; 368 NavigationEntryImpl* pending_entry_;
369 369
370 // Navigations could occur in succession. This field holds the last pending 370 // Navigations could occur in succession. This field holds the last pending
371 // entry for which we haven't received a response yet. 371 // entry for which we haven't received a response yet.
372 NavigationEntryImpl* last_pending_entry_; 372 NavigationEntryImpl* last_pending_entry_;
373 373
374 // If a new entry fails loading, details about it are temporarily held here 374 // If a new entry fails loading, details about it are temporarily held here
375 // until the error page is shown (or 0 otherwise). 375 // until the error page is shown (or 0 otherwise).
376 // 376 //
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 // these are ReloadType::NONE and a null timestamp, respectively. 453 // these are ReloadType::NONE and a null timestamp, respectively.
454 ReloadType last_committed_reload_type_; 454 ReloadType last_committed_reload_type_;
455 base::Time last_committed_reload_time_; 455 base::Time last_committed_reload_time_;
456 456
457 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl); 457 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
458 }; 458 };
459 459
460 } // namespace content 460 } // namespace content
461 461
462 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 462 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
OLDNEW
« chrome/browser/android/tab_state.cc ('K') | « chrome/browser/android/tab_state.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698