Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2802133002: Move MediaControlsWindowEventListener to modules/media_controls/. (Closed)
Patch Set: rebase after blink rename Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
index 02ea9eb22d233f9dfde942595193c4e49b6ccc62..e1f6f1788198becd4bb70e21cd61f503d8d13508 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
@@ -87,18 +87,11 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
// Return the internal elements, which is used by registering clicking
// EventHandlers from MediaControlsWindowEventListener.
MediaControlPanelElement* PanelElement() override { return panel_; }
- MediaControlTimelineElement* TimelineElement() override { return timeline_; }
- MediaControlCastButtonElement* CastButtonElement() override {
- return cast_button_;
- }
- MediaControlVolumeSliderElement* VolumeSliderElement() override {
- return volume_slider_;
- }
void BeginScrubbing() override;
void EndScrubbing() override;
void UpdateCurrentTimeDisplay() override;
void ToggleTextTrackList() override;
- void ShowTextTrackAtIndex(unsigned index_to_enable) override;
+ void ShowTextTrackAtIndex(unsigned) override;
void DisableShowingTextTracks() override;
// Called by the fullscreen buttons to toggle fulllscreen on/off.
void EnterFullscreen() override;
@@ -132,7 +125,17 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
DECLARE_VIRTUAL_TRACE();
private:
+ // MediaControlsMediaEventListener is a component that is listening to events
+ // and calling the appropriate callback on MediaControlsImpl. The object is
+ // split from MedaiControlsImpl to reduce boilerplate and ease reading. In
+ // order to not expose accessors only for this component, a friendship is
+ // declared.
friend class MediaControlsMediaEventListener;
+ // Same as above but handles the menus hiding when the window is interacted
+ // with, allowing MediaControlsImpl to not have the boilerplate.
+ friend class MediaControlsWindowEventListener;
+
+ // For tests.
friend class MediaControlsOrientationLockDelegateTest;
friend class MediaControlsImplTest;

Powered by Google App Engine
This is Rietveld 408576698